-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Side-step ICE on RePlaceholder
in eval_verify_bound
#89890
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
r? @rust-lang/borrowck |
This comment has been minimized.
This comment has been minimized.
I had a look at this, and I think that the correct fix is to replace the placeholder regions in the type here rust/compiler/rustc_borrowck/src/type_check/constraint_conversion.rs Lines 98 to 111 in 40ebd07
Do you want to update this PR to do that, or should I open a new PR with that change? |
@matthewjasper would you have the time to open a PR doing the change you propose? I'm a bit swamped at the moment. You can close this PR if you do so. I'll keep this one open for now just as a note to self, to remind me to look at this if there's no movement in the medium term. |
Opened #91321 |
Address #76168.
I don't think this is the correct way of handling this, but it does get rid of a stable-to-stable regression ICE.
The previous output (before the regression) was:
while the output with this PR is