Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Add static size assertion for clean::Type #89989

Merged
merged 1 commit into from
Oct 18, 2021
Merged

rustdoc: Add static size assertion for clean::Type #89989

merged 1 commit into from
Oct 18, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Oct 17, 2021 •
edited
Loading

r? @jyn514

@camelid camelid added I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. I-compiletime Issue: Problems and improvements with respect to compile times. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 17, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2021
@camelid
Copy link
Member Author

camelid commented Oct 17, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 17, 2021
@bors
Copy link
Contributor

bors commented Oct 17, 2021

⌛ Trying commit f7189338fafe6537fe7f7970b5d57eed5cd7a3f6 with merge d0b6d2d34c195e800b1db37f81519e2468e73e88...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camelid
Copy link
Member Author

camelid commented Oct 17, 2021

@bors try

@bors
Copy link
Contributor

bors commented Oct 17, 2021

⌛ Trying commit 4e5bcebb2faea58163cffaa8ff7b9f9ae4f3bcdd with merge bf3391bc963c595358ede3c3bcbabcabc9e0bb3e...

@jyn514 jyn514 changed the title rustdoc: Shrink Type from 72 to 64 bytes rustdoc: Box trait_ field to reduce Type from 72 to 64 bytes Oct 17, 2021
@bors
Copy link
Contributor

bors commented Oct 17, 2021

☀️ Try build successful - checks-actions
Build commit: bf3391bc963c595358ede3c3bcbabcabc9e0bb3e (bf3391bc963c595358ede3c3bcbabcabc9e0bb3e)

@rust-timer
Copy link
Collaborator

Queued bf3391bc963c595358ede3c3bcbabcabc9e0bb3e with parent 8db8f48, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bf3391bc963c595358ede3c3bcbabcabc9e0bb3e): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 18, 2021
@jyn514
Copy link
Member

jyn514 commented Oct 18, 2021

Looks like no change in compiletime and a moderate regression for memory on tokio-webpush-simple-doc. So I think this should be closed unless you have ideas for improving it.

@camelid
Copy link
Member Author

camelid commented Oct 18, 2021

Actually, there are a lot of small improvements:

image

@jyn514
Copy link
Member

jyn514 commented Oct 18, 2021

Those are very small, though ... I don't know if the improvement is worth it.

@camelid
Copy link
Member Author

camelid commented Oct 18, 2021

Well, up to you. I think we should at least keep the static size assertion for Type, so I can drop the boxing commit.

@jyn514
Copy link
Member

jyn514 commented Oct 18, 2021

I think we should at least keep the static size assertion for Type, so I can drop the boxing commit

👍 Seems good, r=me with that done

@camelid camelid changed the title rustdoc: Box trait_ field to reduce Type from 72 to 64 bytes rustdoc: Add static size assertion for clean::Type Oct 18, 2021
@camelid
Copy link
Member Author

camelid commented Oct 18, 2021

@bors r=jyn514 rollup

@bors
Copy link
Contributor

bors commented Oct 18, 2021

📌 Commit 10b9b3d has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2021
@camelid camelid removed I-compiletime Issue: Problems and improvements with respect to compile times. I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. labels Oct 18, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 18, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 18, 2021
@bors
Auto merge of rust-lang#90000 - matthiaskrgr:rollup-vj7wwur, r=matthi…
5dab47d 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#89950 (bootstrap: tweak verbosity settings)
 - rust-lang#89965 (Fix ICE with `let...else` and `ref mut`)
 - rust-lang#89974 (Nicer error message if the user attempts to do let...else if)
 - rust-lang#89987 (Check implementing type for `#[doc(hidden)]`)
 - rust-lang#89989 (rustdoc: Add static size assertion for `clean::Type`)
 - rust-lang#89990 (rustc_span: `Ident::invalid` -> `Ident::empty`)
 - rust-lang#89993 (Remove dead code from `compiletest::json`)
 - rust-lang#89996 (Bump backtrace)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 874f19f into rust-lang:master Oct 18, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 18, 2021
@camelid camelid deleted the type-size branch October 18, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
7 participants
@camelid @rust-timer @bors @rust-log-analyzer @jyn514 @rust-highfive @rustbot