BTree: improve public descriptions and comments #91749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
camelid
added
the
T-libs-api
|
Hm, elements feels like a not significant improvement over values, I feel like it's easy to read that as values, not the keys -- maybe something like "key-value pairs" is more clear cut? |
Mark-Simulacrum
added
S-waiting-on-author
|
I don't understand what you mean at all. But I didn't look beyond math and btree.
If you agree "values" is confusing, obvious names are "elements" or "keys". "key-value pairs" makes no sense to me - it's |
|
Ah, I think I somehow intuited this was modifying both map and set. For set I agree elements seems good, apologies for the confusion. @bors r+ rollup |
|
📌 Commit 27b4b19 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 13, 2021
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#91086 (Implement `TryFrom<&'_ mut [T]>` for `[T; N]`) - rust-lang#91091 (Stabilize `ControlFlow::{is_break, is_continue}`) - rust-lang#91749 (BTree: improve public descriptions and comments) - rust-lang#91819 (rustbot: Add autolabeling for `T-compiler`) - rust-lang#91824 (Make `(*mut T)::write_bytes` `const`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTreeSet has always used the term "value" next to and meaning the same thing as "elements" (in the mathematical sense but also used for key-value pairs in BTreeMap), while in the BTreeMap sense these "values" are known as "keys" and definitely not "values". Today I had enough of that.
r? @Mark-Simulacrum