Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tcx.def_path_hash in ExistentialPredicate.stable_cmp #91920

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Use tcx.def_path_hash in ExistentialPredicate.stable_cmp #91920

merged 1 commit into from
Dec 15, 2021

Conversation

Aaron1011
Copy link
Member

This avoids a needless query invocation

@Aaron1011
Use tcx.def_path_hash in ExistentialPredicate.stable_cmp
4d1d66b 
This avoids a needless query invocation
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 14, 2021
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2021
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 14, 2021
@bors
Copy link
Contributor

bors commented Dec 14, 2021

⌛ Trying commit 4d1d66b with merge 8fed3a85418593390deb358b204d96de6346dc0b...

@bors
Copy link
Contributor

bors commented Dec 14, 2021

☀️ Try build successful - checks-actions
Build commit: 8fed3a85418593390deb358b204d96de6346dc0b (8fed3a85418593390deb358b204d96de6346dc0b)

@rust-timer
Copy link
Collaborator

Queued 8fed3a85418593390deb358b204d96de6346dc0b with parent 404c847, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8fed3a85418593390deb358b204d96de6346dc0b): comparison url.

Summary: This change led to large relevant improvements 🎉 in compiler performance.

  • Large improvement in instruction counts (up to -3.9% on incr-unchanged builds of deep-vector)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 14, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Dec 14, 2021

Perf doesn't see any changes in execution count and the one big perf change is likely noise

@Aaron1011
Copy link
Member Author

If this is perf-neutral, I think we should merge it. There's no reason to perform a redundant query here, and this will unblock #91919

@oli-obk
Copy link
Contributor

oli-obk commented Dec 14, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 14, 2021

📌 Commit 4d1d66b has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2021
@matthiaskrgr
Rollup merge of rust-lang#91920 - Aaron1011:pred-stable-cmp, r=oli-obk
68c5cd2 
Use `tcx.def_path_hash` in `ExistentialPredicate.stable_cmp`

This avoids a needless query invocation
This was referenced Dec 14, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2021
@bors
Auto merge of rust-lang#91962 - matthiaskrgr:rollup-2g082jw, r=matthi…
c5ecc15 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#91880 (fix clippy::single_char_pattern perf findings)
 - rust-lang#91885 (Remove `in_band_lifetimes` from `rustc_codegen_ssa`)
 - rust-lang#91898 (Make `TyS::is_suggestable` check for non-suggestable types structually)
 - rust-lang#91915 (Add another regression test for unnormalized fn args with Self)
 - rust-lang#91916 (Fix a bunch of typos)
 - rust-lang#91918 (Constify `bool::then{,_some}`)
 - rust-lang#91920 (Use `tcx.def_path_hash` in `ExistentialPredicate.stable_cmp`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 990cf5b into rust-lang:master Dec 15, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Aaron1011 @rust-highfive @rust-timer @bors @oli-obk @rustbot