Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Remove unused collapsed field #92077

Merged
merged 1 commit into from
Dec 19, 2021
Merged

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 18, 2021

render/context always runs after run_global_context, so it was always set to true.

This is a holdover from when rustdoc allowed configuring passes, but the collapse-docs pass was
removed ages ago, and the ability to configure passes is about to be removed.

Found while reviewing #91305.

`render/context` always runs after `run_global_context`, so it was always set to `true`.

This is a holdover from when rustdoc allowed configuring passes, but the `collapse-docs` pass was
removed ages ago, and the ability to configure passes is about to be removed.
@rust-highfive
Copy link
Collaborator

Some changes occurred in clean/types.rs.

cc @camelid

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 18, 2021
@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2021
@jyn514
Copy link
Member Author

jyn514 commented Dec 18, 2021

r? @camelid

@jyn514 jyn514 added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Dec 18, 2021
@jyn514 jyn514 changed the title Remove collapsed field rustdoc: Remove unused collapsed field Dec 18, 2021
@jyn514
Copy link
Member Author

jyn514 commented Dec 18, 2021

@bors r=GuillaumeGomez rollup

Thanks for the review!

@bors
Copy link
Contributor

bors commented Dec 18, 2021

📌 Commit dea1c68 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2021
@camelid camelid assigned GuillaumeGomez and unassigned camelid Dec 18, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2021
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#91141 (Revert "Temporarily rename int_roundings functions to avoid conflicts")
 - rust-lang#91984 (Remove `in_band_lifetimes` from `rustc_middle`)
 - rust-lang#92028 (Sync portable-simd to fix libcore build for AVX-512 enabled targets)
 - rust-lang#92042 (Enable `#[thread_local]` for all windows-msvc targets)
 - rust-lang#92071 (Update example code for Vec::splice to change the length)
 - rust-lang#92077 (rustdoc: Remove unused `collapsed` field)
 - rust-lang#92081 (rustdoc: Remove unnecessary `need_backline` function)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1f080f6 into rust-lang:master Dec 19, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 19, 2021
@jyn514 jyn514 deleted the remove-collapsed branch February 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants