-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Misc incr comp improvements around span hashing invalidation #92204
Conversation
This causes us to miss legitimate evaluatiosn (e.g. an upstream `ExpnId` no longer exists), leading to ICEs when decoding stale values from the incremental cache.
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit eef9f4c with merge 6ab07dabd4dd50e695e1a20f09fb4efb077af4d9... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
It looks like some of the newly-hashed spans are leaking into the |
Span
field when hashing some Ident
s
☔ The latest upstream changes (presumably #92534) made this pull request unmergeable. Please resolve the merge conflicts. |
#91921 was fixed by a different PR, so this PR is no longer needed. |
Fixes #91921
Fixes #92192
As expected, this causes a lot of new incremental invalidations. This PR currently contains some experiments to reduce the number of invalidations we run into in practice.