Implement RFC 3151: Scoped threads. #92555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now panic!()s on its own, rather than resume_unwind'ing the panic payload from the thread. Using resume_unwind skips the panic_handler, meaning that the main thread would never have a panic handler run, which can get confusing.
rust-highfive
added
the
S-waiting-on-review
m-ou-se
added
T-libs
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jacob Lifshay <[email protected]>
Co-authored-by: Mattias Buelens <[email protected]>
m-ou-se
force-pushed
the
scoped-threads
branch
from
9201db9
to
c429ade
Compare
zesterer
reviewed
Jan 4, 2022
deltragon
reviewed
Jan 4, 2022
Co-authored-by: deltragon <[email protected]>
Amanieu
reviewed
Jan 5, 2022
frewsxcv
reviewed
Jan 5, 2022
Co-authored-by: Amanieu d'Antras <[email protected]>
10 tasks
m-ou-se
added
S-waiting-on-author
|
@Amanieu I've added the tracking issue number, so this is now ready for review/merging. |
|
@bors r+ |
|
📌 Commit 465c405 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 23, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#91526 (rustc_lint: Some early linting refactorings) - rust-lang#92555 (Implement RFC 3151: Scoped threads.) - rust-lang#93213 (Fix `let_chains` and `if_let_guard` feature flags) - rust-lang#93219 (Add preliminary support for inline assembly for msp430.) - rust-lang#93226 (Normalize field access types during borrowck) - rust-lang#93227 (Liberate late bound regions when collecting GAT substs in wfcheck) - rust-lang#93229 (Remove DiagnosticBuilder.quiet) - rust-lang#93234 (rustc_mir_itertools: Avoid needless `collect` with itertools) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements rust-lang/rfcs#3151
Tracking issue: #93203
r? @Amanieu