Fix drop shadow on Rust logo in docs #92605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Looks good to me, thanks! Can you add a GUI test for this please? (for the 3 themes in both doc view and source view) |
|
Fixed in #92764 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/rust-lang/rust/pull/91958/files I fixed the logo so it only gets the
rust-logoclass when it really is the default logo. However, as part of that I also moved the class from a parent div to the img itself, and forgot to update the corresponding CSS rules.r? @GuillaumeGomez
Demo: https://rustdoc.crud.net/jsha/logo-tracing/std/io/trait.Read.html