Add manifest docs fallback. #92800

ehuss · 2022-01-12T01:03:03Z

This adds a fallback so that the rustup manifest will contain the rust-docs component for all hosts. There is a mapping so that the docs that get downloaded are roughly close to the actual host. There inevitably will be things that don't match. Ideally the standard library docs would be the same for every platform (cfg(doc) goes a long way towards this), but there are still lots of minor differences.

Closes #69525

rust-highfive · 2022-01-12T01:03:07Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

ehuss · 2022-01-12T01:05:37Z

I did a little bit of testing locally, and rustup seems to work with this new manifest. It downloads the docs and rustup strips the first directory component, so the paths just work.

Let me know if you want to somehow do more testing. It's a bit difficult to feel confident this won't break everything. 😬

Mark-Simulacrum · 2022-01-17T17:04:47Z

If you could enable a scattering of affected dist builders (maybe 4-5) and run a try build, I can make a dev-static nightly release from it which we can use to test rustup and such -- that would give us more confidence in landing this.

cc @kinnison

The version was removed in rust-lang#77145

ehuss · 2022-01-17T17:42:06Z

Sure, I haven't done a try build like this, hopefully it doesn't disrupt things.

@bors try

bors · 2022-01-17T17:42:13Z

⌛ Trying commit 1b9a17e0fd610e44b8646632ac3588589bec728e with merge d7c256d9d865592ff16af19f007980a1fc397873...

ehuss · 2022-01-17T18:32:41Z

@bors try

I forgot to disable docs on aarch64-apple

bors · 2022-01-17T18:32:51Z

⌛ Trying commit c0ef083298378c45637d9643697d36f574078a6d with merge 4ea8b01f08bbc8c92530a9d9045517a287a84875...

bors · 2022-01-17T20:55:28Z

💔 Test failed - checks-actions

ehuss · 2022-01-17T21:14:10Z

Erg, fixed the docs error.

@bors try

bors · 2022-01-17T21:14:18Z

⌛ Trying commit 163a5bf2e189c6142961cbee6f1d3efecd4d5dff with merge 92effb4fe7197d4d2b84dbe9c3ba45228fb5ce2e...

bors · 2022-01-18T00:49:50Z

☀️ Try build successful - checks-actions
Build commit: 92effb4fe7197d4d2b84dbe9c3ba45228fb5ce2e (92effb4fe7197d4d2b84dbe9c3ba45228fb5ce2e)

ehuss · 2022-01-18T00:55:51Z

Ok, @Mark-Simulacrum, I think try build 92effb4fe7197d4d2b84dbe9c3ba45228fb5ce2e is ready.

Mark-Simulacrum · 2022-01-18T03:05:33Z

Kicked off a nightly based on that try commit, artifacts should be ready relatively soon (~1 hour or so) -- RUSTUP_DIST_SERVER=https://dev-static.rust-lang.org rustup toolchain install nightly.

This builder is the slowest in the fleet. This should cut a considerable amount of time. The manifest should now include the docs from x86_64-apple-darwin. Although those docs are slightly different, it should be close enough. When aarch64-apple-darwin heads towards tier 1, we can revisit whether or not to re-enable the docs.

ehuss · 2022-01-18T04:23:03Z

Cool, I downloaded the 5 different platforms, and they all include rust-docs. I checked that each platform contains the appropriate files (aarch64-apple-darwin is a complete duplicate of x86_64-apple-darwin, for example).

I pushed a new commit that disables docs for dist-aarch64-apple in order to reduce the total time for that job. I could make that a separate PR, but it seems easier to bundle it here.

ehuss · 2022-01-18T04:24:58Z

And just checking the manifest:

[pkg.rust-docs.target.aarch64-apple-darwin]
available = true
url = "https://dev-static.rust-lang.org/dist/2022-01-18/rust-docs-nightly-x86_64-apple-darwin.tar.gz"
hash = "459f0987a1a2f1711296b711114959d9431a2282e0de2ead5b51d4e03dec2c0c"
xz_url = "https://dev-static.rust-lang.org/dist/2022-01-18/rust-docs-nightly-x86_64-apple-darwin.tar.xz"
xz_hash = "2024f8d16e16cf17ddf13121d3aa83b1e1eafd22dc7e77551d590d6c86d0205c"

and

[pkg.rust-docs.target.arm-unknown-linux-gnueabi]
available = true
url = "https://dev-static.rust-lang.org/dist/2022-01-18/rust-docs-nightly-aarch64-unknown-linux-gnu.tar.gz"
hash = "08bf359d3a989910f0f159f6ad03904294667769cab4c7baf77be32aa815b9f1"
xz_url = "https://dev-static.rust-lang.org/dist/2022-01-18/rust-docs-nightly-aarch64-unknown-linux-gnu.tar.xz"
xz_hash = "e57f124ba31293806cd9dee8b67ae87a217aa08ec1b33f4cd522704066834686"

Mark-Simulacrum

r=me presuming comment is correct in my understanding

Mark-Simulacrum · 2022-01-19T14:18:43Z

src/tools/build-manifest/src/main.rs

+/// `host_partial`, it will use the docs from `host_instead` instead.
+///
+/// The order here matters, more specific entries should be first.
+static DOCS_FALLBACK: &[(&str, &str)] = &[


Just to double check my understanding: this does not make us lose checking that e.g. x86_64-pc-windows-gnu shipped a rust-docs tarball, right? (If I'm reading the old code right, we never had checking of that kind).

It would generally be nice to assert somewhere that the builders we want to fallback are -- e.g., that aarch64-apple-darwin isn't producing a rust-docs tarball. I guess we can chalk that up to my (future) hope for a more general scheme that lets us check which tests/steps ran on which builders (or didn't run).

Right, there weren't any checks before (except for the oddity that apple-darwin was hard-coded to require it). I added an assert to check that the fallback exists.

ehuss · 2022-01-19T17:55:25Z

@bors r=Mark-Simulacrum

bors · 2022-01-19T17:55:27Z

📌 Commit c8e6889 has been approved by Mark-Simulacrum

…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#92316 (mangling_v0: Skip extern blocks during mangling) - rust-lang#92630 (Change PhantomData type for `BuildHasherDefault` (and more)) - rust-lang#92800 (Add manifest docs fallback.) - rust-lang#93005 (Move back templates into html folder) - rust-lang#93065 (Pretty printer algorithm revamp step 2) - rust-lang#93077 (remove `List::is_noop`) Failed merges: - rust-lang#93068 (Fix spacing for `·` between stability and source) r? `@ghost` `@rustbot` modify labels: rollup

Mark-Simulacrum · 2022-01-24T18:23:15Z

The individual PRs are pretty high variance, so it's somewhat hard to tell, but it seems pretty likely that this PR is responsible for the significant drop in aarch64 runtime in the last week or so. Great work, thanks @ehuss!

KevinDCarlson · 2022-01-30T02:05:07Z

Sorry to barge in, new Rust user here on ARM Mac--do I see from ehuss's comment 1/17 that rust-docs is disabled for me, and there's currently no way to make it fall back to Intel docs?

ehuss · 2022-01-30T15:57:52Z

@KevinArlin Sorry, I don't understand your question. If you are installing aarch64-apple-darwin, you should receive the x86_64-apple-darwin documentation. If it isn't can you open an issue with more details on exactly what you tried and why it doesn't seem to work?

KevinDCarlson · 2022-01-31T19:58:46Z

OK, I did so here.

…rk-Simulacrum Update note about tier 2 docs. As of rust-lang#92800, docs are now available for tier-2 platforms.

Pkgsrc changes: * Bump available bootstraps to 1.59.0. * Delete one patch which no longer applies, adjust another. Upstream changes: Version 1.60.0 (2022-04-07) ========================== Language -------- - [Stabilize `#[cfg(panic = "...")]` for either `"unwind"` or `"abort"`.] [93658] - [Stabilize `#[cfg(target_has_atomic = "...")]` for each integer size and `"ptr"`.][93824] Compiler -------- - [Enable combining `+crt-static` and `relocation-model=pic` on `x86_64-unknown-linux-gnu`][86374] - [Fixes wrong `unreachable_pub` lints on nested and glob public reexport][87487] - [Stabilize `-Z instrument-coverage` as `-C instrument-coverage`][90132] - [Stabilize `-Z print-link-args` as `--print link-args`][91606] - [Add new Tier 3 target `mips64-openwrt-linux-musl`\*][92300] - [Add new Tier 3 target `armv7-unknown-linux-uclibceabi` (softfloat)\*][92383] - [Fix invalid removal of newlines from doc comments][92357] - [Add kernel target for RustyHermit][92670] - [Deny mixing bin crate type with lib crate types][92933] - [Make rustc use `RUST_BACKTRACE=full` by default][93566] - [Upgrade to LLVM 14][93577] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Guarantee call order for `sort_by_cached_key`][89621] - [Improve `Duration::try_from_secs_f32`/`f64` accuracy by directly processing exponent and mantissa][90247] - [Make `Instant::{duration_since, elapsed, sub}` saturating][89926] - [Remove non-monotonic clocks workarounds in `Instant::now`][89926] - [Make `BuildHasherDefault`, `iter::Empty` and `future::Pending` covariant][92630] Stabilized APIs --------------- - [`Arc::new_cyclic`][arc_new_cyclic] - [`Rc::new_cyclic`][rc_new_cyclic] - [`slice::EscapeAscii`][slice_escape_ascii] - [`<[u8]>::escape_ascii`][slice_u8_escape_ascii] - [`u8::escape_ascii`][u8_escape_ascii] - [`Vec::spare_capacity_mut`][vec_spare_capacity_mut] - [`MaybeUninit::assume_init_drop`][assume_init_drop] - [`MaybeUninit::assume_init_read`][assume_init_read] - [`i8::abs_diff`][i8_abs_diff] - [`i16::abs_diff`][i16_abs_diff] - [`i32::abs_diff`][i32_abs_diff] - [`i64::abs_diff`][i64_abs_diff] - [`i128::abs_diff`][i128_abs_diff] - [`isize::abs_diff`][isize_abs_diff] - [`u8::abs_diff`][u8_abs_diff] - [`u16::abs_diff`][u16_abs_diff] - [`u32::abs_diff`][u32_abs_diff] - [`u64::abs_diff`][u64_abs_diff] - [`u128::abs_diff`][u128_abs_diff] - [`usize::abs_diff`][usize_abs_diff] - [`Display for io::ErrorKind`][display_error_kind] - [`From<u8> for ExitCode`][from_u8_exit_code] - [`Not for !` (the "never" type)][not_never] - [_Op_`Assign<$t> for Wrapping<$t>`][wrapping_assign_ops] - [`arch::is_aarch64_feature_detected!`][is_aarch64_feature_detected] Cargo ----- - [Port cargo from `toml-rs` to `toml_edit`][cargo/10086] - [Stabilize `-Ztimings` as `--timings`][cargo/10245] - [Stabilize namespaced and weak dependency features.][cargo/10269] - [Accept more `cargo:rustc-link-arg-*` types from build script output.][cargo/10274] - [cargo-new should not add ignore rule on Cargo.lock inside subdirs][cargo/10379] Misc ---- - [Ship docs on Tier 2 platforms by reusing the closest Tier 1 platform docs][92800] - [Drop rustc-docs from complete profile][93742] - [bootstrap: tidy up flag handling for llvm build][93918] Compatibility Notes ------------------- - [Remove compiler-rt linking hack on Android][83822] - [Mitigations for platforms with non-monotonic clocks have been removed from `Instant::now`][89926]. On platforms that don't provide monotonic clocks, an instant is not guaranteed to be greater than an earlier instant anymore. - [`Instant::{duration_since, elapsed, sub}` do not panic anymore on underflow, saturating to `0` instead][89926]. In the real world the panic happened mostly on platforms with buggy monotonic clock implementations rather than catching programming errors like reversing the start and end times. Such programming errors will now results in `0` rather than a panic. - In a future release we're planning to increase the baseline requirements for the Linux kernel to version 3.2, and for glibc to version 2.17. We'd love your feedback in [PR #95026][95026]. Internal Changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Switch all libraries to the 2021 edition][92068] [83822]: rust-lang/rust#83822 [86374]: rust-lang/rust#86374 [87487]: rust-lang/rust#87487 [89621]: rust-lang/rust#89621 [89926]: rust-lang/rust#89926 [90132]: rust-lang/rust#90132 [90247]: rust-lang/rust#90247 [91606]: rust-lang/rust#91606 [92068]: rust-lang/rust#92068 [92300]: rust-lang/rust#92300 [92357]: rust-lang/rust#92357 [92383]: rust-lang/rust#92383 [92630]: rust-lang/rust#92630 [92670]: rust-lang/rust#92670 [92800]: rust-lang/rust#92800 [92933]: rust-lang/rust#92933 [93566]: rust-lang/rust#93566 [93577]: rust-lang/rust#93577 [93658]: rust-lang/rust#93658 [93742]: rust-lang/rust#93742 [93824]: rust-lang/rust#93824 [93918]: rust-lang/rust#93918 [95026]: rust-lang/rust#95026 [cargo/10086]: rust-lang/cargo#10086 [cargo/10245]: rust-lang/cargo#10245 [cargo/10269]: rust-lang/cargo#10269 [cargo/10274]: rust-lang/cargo#10274 [cargo/10379]: rust-lang/cargo#10379 [arc_new_cyclic]: https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#method.new_cyclic [rc_new_cyclic]: https://doc.rust-lang.org/stable/std/rc/struct.Rc.html#method.new_cyclic [slice_escape_ascii]: https://doc.rust-lang.org/stable/std/slice/struct.EscapeAscii.html [slice_u8_escape_ascii]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.escape_ascii [u8_escape_ascii]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.escape_ascii [vec_spare_capacity_mut]: https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.spare_capacity_mut [assume_init_drop]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_drop [assume_init_read]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_read [i8_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i8.html#method.abs_diff [i16_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i16.html#method.abs_diff [i32_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i32.html#method.abs_diff [i64_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i64.html#method.abs_diff [i128_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i128.html#method.abs_diff [isize_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.isize.html#method.abs_diff [u8_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.abs_diff [u16_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u16.html#method.abs_diff [u32_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u32.html#method.abs_diff [u64_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u64.html#method.abs_diff [u128_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u128.html#method.abs_diff [usize_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.usize.html#method.abs_diff [display_error_kind]: https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#impl-Display [from_u8_exit_code]: https://doc.rust-lang.org/stable/std/process/struct.ExitCode.html#impl-From%3Cu8%3E [not_never]: https://doc.rust-lang.org/stable/std/primitive.never.html#impl-Not [wrapping_assign_ops]: https://doc.rust-lang.org/stable/std/num/struct.Wrapping.html#trait-implementations [is_aarch64_feature_detected]: https://doc.rust-lang.org/stable/std/arch/macro.is_aarch64_feature_detected.html

Pkgsrc changes: * Bump available bootstraps to 1.59.0. * Adjust line number in patches which had non-zero offsets. Upstream changes: Version 1.60.0 (2022-04-07) =========================== Language -------- - [Stabilize `#[cfg(panic = "...")]` for either `"unwind"` or `"abort"`.] [93658] - [Stabilize `#[cfg(target_has_atomic = "...")]` for each integer size and `"ptr"`.][93824] Compiler -------- - [Enable combining `+crt-static` and `relocation-model=pic` on `x86_64-unknown-linux-gnu`][86374] - [Fixes wrong `unreachable_pub` lints on nested and glob public reexport][87487] - [Stabilize `-Z instrument-coverage` as `-C instrument-coverage`][90132] - [Stabilize `-Z print-link-args` as `--print link-args`][91606] - [Add new Tier 3 target `mips64-openwrt-linux-musl`\*][92300] - [Add new Tier 3 target `armv7-unknown-linux-uclibceabi` (softfloat)\*][92383] - [Fix invalid removal of newlines from doc comments][92357] - [Add kernel target for RustyHermit][92670] - [Deny mixing bin crate type with lib crate types][92933] - [Make rustc use `RUST_BACKTRACE=full` by default][93566] - [Upgrade to LLVM 14][93577] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Guarantee call order for `sort_by_cached_key`][89621] - [Improve `Duration::try_from_secs_f32`/`f64` accuracy by directly processing exponent and mantissa][90247] - [Make `Instant::{duration_since, elapsed, sub}` saturating][89926] - [Remove non-monotonic clocks workarounds in `Instant::now`][89926] - [Make `BuildHasherDefault`, `iter::Empty` and `future::Pending` covariant][92630] Stabilized APIs --------------- - [`Arc::new_cyclic`][arc_new_cyclic] - [`Rc::new_cyclic`][rc_new_cyclic] - [`slice::EscapeAscii`][slice_escape_ascii] - [`<[u8]>::escape_ascii`][slice_u8_escape_ascii] - [`u8::escape_ascii`][u8_escape_ascii] - [`Vec::spare_capacity_mut`][vec_spare_capacity_mut] - [`MaybeUninit::assume_init_drop`][assume_init_drop] - [`MaybeUninit::assume_init_read`][assume_init_read] - [`i8::abs_diff`][i8_abs_diff] - [`i16::abs_diff`][i16_abs_diff] - [`i32::abs_diff`][i32_abs_diff] - [`i64::abs_diff`][i64_abs_diff] - [`i128::abs_diff`][i128_abs_diff] - [`isize::abs_diff`][isize_abs_diff] - [`u8::abs_diff`][u8_abs_diff] - [`u16::abs_diff`][u16_abs_diff] - [`u32::abs_diff`][u32_abs_diff] - [`u64::abs_diff`][u64_abs_diff] - [`u128::abs_diff`][u128_abs_diff] - [`usize::abs_diff`][usize_abs_diff] - [`Display for io::ErrorKind`][display_error_kind] - [`From<u8> for ExitCode`][from_u8_exit_code] - [`Not for !` (the "never" type)][not_never] - [_Op_`Assign<$t> for Wrapping<$t>`][wrapping_assign_ops] - [`arch::is_aarch64_feature_detected!`][is_aarch64_feature_detected] Cargo ----- - [Port cargo from `toml-rs` to `toml_edit`][cargo/10086] - [Stabilize `-Ztimings` as `--timings`][cargo/10245] - [Stabilize namespaced and weak dependency features.][cargo/10269] - [Accept more `cargo:rustc-link-arg-*` types from build script output.][cargo/10274] - [cargo-new should not add ignore rule on Cargo.lock inside subdirs][cargo/10379] Misc ---- - [Ship docs on Tier 2 platforms by reusing the closest Tier 1 platform docs][92800] - [Drop rustc-docs from complete profile][93742] - [bootstrap: tidy up flag handling for llvm build][93918] Compatibility Notes ------------------- - [Remove compiler-rt linking hack on Android][83822] - [Mitigations for platforms with non-monotonic clocks have been removed from `Instant::now`][89926]. On platforms that don't provide monotonic clocks, an instant is not guaranteed to be greater than an earlier instant anymore. - [`Instant::{duration_since, elapsed, sub}` do not panic anymore on underflow, saturating to `0` instead][89926]. In the real world the panic happened mostly on platforms with buggy monotonic clock implementations rather than catching programming errors like reversing the start and end times. Such programming errors will now results in `0` rather than a panic. - In a future release we're planning to increase the baseline requirements for the Linux kernel to version 3.2, and for glibc to version 2.17. We'd love your feedback in [PR #95026][95026]. Internal Changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Switch all libraries to the 2021 edition][92068] [83822]: rust-lang/rust#83822 [86374]: rust-lang/rust#86374 [87487]: rust-lang/rust#87487 [89621]: rust-lang/rust#89621 [89926]: rust-lang/rust#89926 [90132]: rust-lang/rust#90132 [90247]: rust-lang/rust#90247 [91606]: rust-lang/rust#91606 [92068]: rust-lang/rust#92068 [92300]: rust-lang/rust#92300 [92357]: rust-lang/rust#92357 [92383]: rust-lang/rust#92383 [92630]: rust-lang/rust#92630 [92670]: rust-lang/rust#92670 [92800]: rust-lang/rust#92800 [92933]: rust-lang/rust#92933 [93566]: rust-lang/rust#93566 [93577]: rust-lang/rust#93577 [93658]: rust-lang/rust#93658 [93742]: rust-lang/rust#93742 [93824]: rust-lang/rust#93824 [93918]: rust-lang/rust#93918 [95026]: rust-lang/rust#95026 [cargo/10086]: rust-lang/cargo#10086 [cargo/10245]: rust-lang/cargo#10245 [cargo/10269]: rust-lang/cargo#10269 [cargo/10274]: rust-lang/cargo#10274 [cargo/10379]: rust-lang/cargo#10379 [arc_new_cyclic]: https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#method.new_cyclic [rc_new_cyclic]: https://doc.rust-lang.org/stable/std/rc/struct.Rc.html#method.new_cyclic [slice_escape_ascii]: https://doc.rust-lang.org/stable/std/slice/struct.EscapeAscii.html [slice_u8_escape_ascii]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.escape_ascii [u8_escape_ascii]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.escape_ascii [vec_spare_capacity_mut]: https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.spare_capacity_mut [assume_init_drop]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_drop [assume_init_read]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_read [i8_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i8.html#method.abs_diff [i16_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i16.html#method.abs_diff [i32_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i32.html#method.abs_diff [i64_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i64.html#method.abs_diff [i128_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.i128.html#method.abs_diff [isize_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.isize.html#method.abs_diff [u8_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.abs_diff [u16_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u16.html#method.abs_diff [u32_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u32.html#method.abs_diff [u64_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u64.html#method.abs_diff [u128_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.u128.html#method.abs_diff [usize_abs_diff]: https://doc.rust-lang.org/stable/std/primitive.usize.html#method.abs_diff [display_error_kind]: https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#impl-Display [from_u8_exit_code]: https://doc.rust-lang.org/stable/std/process/struct.ExitCode.html#impl-From%3Cu8%3E [not_never]: https://doc.rust-lang.org/stable/std/primitive.never.html#impl-Not [wrapping_assign_ops]: https://doc.rust-lang.org/stable/std/num/struct.Wrapping.html#trait-implementations [is_aarch64_feature_detected]: https://doc.rust-lang.org/stable/std/arch/macro.is_aarch64_feature_detected.html

rust-highfive assigned Mark-Simulacrum Jan 12, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 12, 2022

ehuss mentioned this pull request Jan 12, 2022

Include aarch64-apple-darwin docs in manifest. #92622

Closed

ehuss added 2 commits January 17, 2022 09:34

Add manifest docs fallback.

3c0fb7f

Remove VERSION from manifest readme docs.

52fdd2d

The version was removed in rust-lang#77145

ehuss force-pushed the docs-fallback branch from 50c7e49 to 1b9a17e Compare January 17, 2022 17:40

ehuss force-pushed the docs-fallback branch from 1b9a17e to c0ef083 Compare January 17, 2022 18:32

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2022

ehuss force-pushed the docs-fallback branch from 163a5bf to 77da0f3 Compare January 18, 2022 04:19

ehuss force-pushed the docs-fallback branch from 77da0f3 to 6a1099c Compare January 18, 2022 04:21

Mark-Simulacrum reviewed Jan 19, 2022

View reviewed changes

Add assert that fallback targets must be available.

c8e6889

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2022

matthiaskrgr mentioned this pull request Jan 19, 2022

Rollup of 6 pull requests #93085

Merged

bors merged commit bcb093e into rust-lang:master Jan 20, 2022

rustbot added this to the 1.60.0 milestone Jan 20, 2022

KevinDCarlson mentioned this pull request Jan 31, 2022

Offline docs not installed on aarch64-apple-darwin #93517

Closed

This was referenced Mar 2, 2022

Rust language guide html page seems to be missing on stable-aarch64-apple-darwin builds of Rust #94528

Closed

Update note about tier 2 docs. #94630

Merged

RalfJung added a commit to RalfJung/rust that referenced this pull request Mar 5, 2022

Rollup merge of rust-lang#94630 - ehuss:remove-tier-2-docs-note, r=Ma…

7143bc3

…rk-Simulacrum Update note about tier 2 docs. As of rust-lang#92800, docs are now available for tier-2 platforms.

ehuss mentioned this pull request Mar 10, 2022

Release notes for 1.60.0 #94817

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add manifest docs fallback. #92800

Add manifest docs fallback. #92800

ehuss commented Jan 12, 2022

rust-highfive commented Jan 12, 2022

ehuss commented Jan 12, 2022

Mark-Simulacrum commented Jan 17, 2022

ehuss commented Jan 17, 2022

bors commented Jan 17, 2022

ehuss commented Jan 17, 2022

bors commented Jan 17, 2022

This comment has been minimized.

bors commented Jan 17, 2022

ehuss commented Jan 17, 2022

bors commented Jan 17, 2022

bors commented Jan 18, 2022

ehuss commented Jan 18, 2022

Mark-Simulacrum commented Jan 18, 2022

ehuss commented Jan 18, 2022

ehuss commented Jan 18, 2022

Mark-Simulacrum left a comment

Mark-Simulacrum Jan 19, 2022

ehuss Jan 19, 2022

ehuss commented Jan 19, 2022

bors commented Jan 19, 2022

Mark-Simulacrum commented Jan 24, 2022

KevinDCarlson commented Jan 30, 2022

ehuss commented Jan 30, 2022

KevinDCarlson commented Jan 31, 2022

Add manifest docs fallback. #92800

Add manifest docs fallback. #92800

Conversation

ehuss commented Jan 12, 2022

rust-highfive commented Jan 12, 2022

ehuss commented Jan 12, 2022

Mark-Simulacrum commented Jan 17, 2022

ehuss commented Jan 17, 2022

bors commented Jan 17, 2022

ehuss commented Jan 17, 2022

bors commented Jan 17, 2022

This comment has been minimized.

bors commented Jan 17, 2022

ehuss commented Jan 17, 2022

bors commented Jan 17, 2022

bors commented Jan 18, 2022

ehuss commented Jan 18, 2022

Mark-Simulacrum commented Jan 18, 2022

ehuss commented Jan 18, 2022

ehuss commented Jan 18, 2022

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Mark-Simulacrum Jan 19, 2022

Choose a reason for hiding this comment

ehuss Jan 19, 2022

Choose a reason for hiding this comment

ehuss commented Jan 19, 2022

bors commented Jan 19, 2022

Mark-Simulacrum commented Jan 24, 2022

KevinDCarlson commented Jan 30, 2022

ehuss commented Jan 30, 2022

KevinDCarlson commented Jan 31, 2022