Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Perf experiment with different cargo defaults #94851

Closed
wants to merge 2 commits into from

Conversation

lqd
Copy link
Member

@lqd lqd commented Mar 11, 2022

I'm not sure this is even going to build on CI, or whether the results I see locally are going to show up on perf.rlo: the collector mostly benchmarks leaf crates and this changes how the dependencies are built, not the leaf crate.

Maybe it'll have an effect on bootstrap.

In any case it'll at least show whether this is the correct way to benchmark with a different cargo.

r? @ghost

@rust-log-analyzer

This comment was marked as outdated.

@lqd
Copy link
Member Author

lqd commented Mar 11, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 11, 2022
@bors
Copy link
Contributor

bors commented Mar 11, 2022

⌛ Trying commit 0a122f4 with merge 69f654c9aa82e79f56e16f66b3c8a17019ac7289...

@Dylan-DPC Dylan-DPC marked this pull request as draft March 11, 2022 16:09
@bors
Copy link
Contributor

bors commented Mar 11, 2022

☀️ Try build successful - checks-actions
Build commit: 69f654c9aa82e79f56e16f66b3c8a17019ac7289 (69f654c9aa82e79f56e16f66b3c8a17019ac7289)

@rust-timer
Copy link
Collaborator

Queued 69f654c9aa82e79f56e16f66b3c8a17019ac7289 with parent f58d51b, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (69f654c9aa82e79f56e16f66b3c8a17019ac7289): comparison url.

Summary: This benchmark run shows 31 relevant improvements 🎉 to instruction counts.

  • Arithmetic mean of relevant regressions: 0.4%
  • Arithmetic mean of relevant improvements: -1.5%
  • Arithmetic mean of all relevant changes: -1.4%
  • Largest improvement in instruction counts: -6.6% on incr-unchanged builds of cargo check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 11, 2022
@lqd lqd closed this Mar 11, 2022
@lqd lqd deleted the cargo-build-defaults branch March 11, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants