-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Nonterminal::NtTT
.
#95301
Remove Nonterminal::NtTT
.
#95301
Conversation
Thanks for the idea! |
It's only needed for macro expansion, not as a general element in the AST. This commit removes it, adds `NtOrTt` for the parser and macro expansion cases, and renames the variants in `NamedMatch` to better match the new type.
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 364b908 with merge b02efedc33c45b1ba76708f34fd5c8446828d9da... |
☀️ Try build successful - checks-actions |
Queued b02efedc33c45b1ba76708f34fd5c8446828d9da with parent ab0c2e1, future comparison URL. |
Finished benchmarking commit (b02efedc33c45b1ba76708f34fd5c8446828d9da): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
Performance effects are negligible, as expected. @bors rollup=always |
@bors r+ |
📌 Commit 364b908 has been approved by |
Rollup of 6 pull requests Successful merges: - rust-lang#95301 (Remove `Nonterminal::NtTT`.) - rust-lang#95314 (Tell users that `||` operators are not currently supported in let chain expressions) - rust-lang#95350 (resolve: Simplify some diagnostic code to avoid an ICE) - rust-lang#95370 ([bootstrap] Don't print `Suite not skipped` unless `--verbose` is set) - rust-lang#95390 (Ignore doc comments in a declarative macro matcher.) - rust-lang#95401 (Remove duplicated and unused test files) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
It's only needed for macro expansion, not as a general element in the
AST. This commit removes it, adds
NtOrTt
for the parser and macroexpansion cases, and renames the variants in
NamedMatch
to bettermatch the new type.
r? @petrochenkov