std: Add capacity guarantees notes for OsString #95394
Conversation
Signed-off-by: Xuanwo <[email protected]>
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@rustbot modify labels: +T-libs-api |
rustbot
added
the
T-libs-api
|
r? @dtolnay |
dtolnay
added
the
needs-fcp
There was a problem hiding this comment.
I think copying the same cursory 1-sentence comment into 7 different places is not the best way to accomplish this documentation. I would prefer to see a single section that explains this topic more clearly in detail, probably with example code to illustrate some correct and incorrect uses of the APIs where this guarantee is relevant. Especially showing the incorrect case is important to illustrate the limitations of this guarantee (the "not specified" case).
This section would probably be most appropriate on the OsString type but alternatively on the capacity() method could work too, depending on how you write it. Everywhere else where that content is important to understand can just link to it.
dtolnay
added
S-waiting-on-author
|
Updated version in #97202 . |
…ntation, r=dtolnay os str capacity documentation This is based on rust-lang#95394 , with expansion and consolidation to address comments from `@dtolnay` and other `@rust-lang/libs-api` team members.
…r=dtolnay os str capacity documentation This is based on rust-lang/rust#95394 , with expansion and consolidation to address comments from `@dtolnay` and other `@rust-lang/libs-api` team members.
This PR intends to stabilize feature
try_reserve_2, part of #91789This PR will is split from #95392