-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #95650
Rollup of 6 pull requests #95650
Commits on Mar 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 02dbf24 - Browse repository at this point
Copy the full SHA 02dbf24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a49636 - Browse repository at this point
Copy the full SHA 1a49636View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7382f22 - Browse repository at this point
Copy the full SHA 7382f22View commit details -
Configuration menu - View commit details
-
Copy full SHA for d47fba7 - Browse repository at this point
Copy the full SHA d47fba7View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc3d57c - Browse repository at this point
Copy the full SHA fc3d57cView commit details
Commits on Mar 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 750ab03 - Browse repository at this point
Copy the full SHA 750ab03View commit details -
Configuration menu - View commit details
-
Copy full SHA for f225808 - Browse repository at this point
Copy the full SHA f225808View commit details
Commits on Mar 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5475047 - Browse repository at this point
Copy the full SHA 5475047View commit details
Commits on Apr 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b899251 - Browse repository at this point
Copy the full SHA b899251View commit details
Commits on Apr 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7370540 - Browse repository at this point
Copy the full SHA 7370540View commit details
Commits on Apr 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for def863d - Browse repository at this point
Copy the full SHA def863dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62f37da - Browse repository at this point
Copy the full SHA 62f37daView commit details -
Configuration menu - View commit details
-
Copy full SHA for b81d430 - Browse repository at this point
Copy the full SHA b81d430View commit details -
Configuration menu - View commit details
-
Copy full SHA for e393ed7 - Browse repository at this point
Copy the full SHA e393ed7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91beb32 - Browse repository at this point
Copy the full SHA 91beb32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c0de7b - Browse repository at this point
Copy the full SHA 9c0de7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for af8b6b6 - Browse repository at this point
Copy the full SHA af8b6b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82eedae - Browse repository at this point
Copy the full SHA 82eedaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b9cd5b - Browse repository at this point
Copy the full SHA 1b9cd5bView commit details -
Rollup merge of rust-lang#94817 - cuviper:relnotes-1.60.0, r=pietroal…
…bini,m-ou-se Release notes for 1.60.0
Configuration menu - View commit details
-
Copy full SHA for a09edbc - Browse repository at this point
Copy the full SHA a09edbcView commit details -
Rollup merge of rust-lang#95431 - golddranks:stabilize_total_cmp, r=s…
…cottmcm Stabilize total_cmp Stabilises `total_cmp` for Rust 1.61.0. Tracking issue: rust-lang#72599
Configuration menu - View commit details
-
Copy full SHA for cf72188 - Browse repository at this point
Copy the full SHA cf72188View commit details -
Rollup merge of rust-lang#95438 - m-ou-se:sync-unsafe-cell, r=joshtri…
…plett Add SyncUnsafeCell. This adds `SyncUnsafeCell`, which is just `UnsafeCell` except it implements `Sync`. This was first proposed under the name `RacyUnsafeCell` here: rust-lang#53639 (comment) and here: rust-lang#53639 (comment) and here: rust-lang#53639 (comment) It allows you to create an UnsafeCell that is Sync without having to wrap it in a struct first (and then implement Sync for that struct). E.g. `static X: SyncUnsafeCell<i32>`. Using a regular `UnsafeCell` as `static` is not possible, because it isn't `Sync`. We have a language workaround for it called `static mut`, but it's nice to be able to use the proper type for such unsafety instead. It also makes implementing synchronization primitives based on unsafe cells slightly less verbose, because by using `SyncUnsafeCell` for `UnsafeCell`s that are shared between threads, you don't need a separate `impl<..> Sync for ..`. Using this type also clearly documents that the cell is expected to be accessed from multiple threads.
Configuration menu - View commit details
-
Copy full SHA for 6100441 - Browse repository at this point
Copy the full SHA 6100441View commit details -
Rollup merge of rust-lang#95467 - ChrisDenton:async-read-pipe, r=josh…
…triplett Windows: Synchronize asynchronous pipe reads and writes On Windows, the pipes used for spawned processes are opened for asynchronous access but `read` and `write` are done using the standard methods that assume synchronous access. This means that the buffer (and variables on the stack) may be read/written to after the function returns. This PR ensures reads/writes complete before returning. Note that this only applies to pipes we create and does not affect the standard file read/write methods. Fixes rust-lang#95411
Configuration menu - View commit details
-
Copy full SHA for 80b352f - Browse repository at this point
Copy the full SHA 80b352fView commit details -
Rollup merge of rust-lang#95588 - RalfJung:strict-provenance, r=scottmcm
explicitly distinguish pointer::addr and pointer::expose_addr `@bgeron` pointed out that the current docs promise that `ptr.addr()` and `ptr as usize` are equivalent. I don't think that is a promise we want to make. (Conceptually, `ptr as usize` might 'escape' the provenance to enable future `usize as ptr` casts, but `ptr.addr()` dertainly does not do that.) So I propose we word the docs a bit more carefully here. `@Gankra` what do you think?
Configuration menu - View commit details
-
Copy full SHA for 298c65c - Browse repository at this point
Copy the full SHA 298c65cView commit details -
Rollup merge of rust-lang#95603 - compiler-errors:dyn-return, r=oli-obk
Fix late-bound ICE in `dyn` return type suggestion This fixes the root-cause of the attached issues -- the root problem is that we're using the return type from a signature with late-bound instead of early-bound regions. The change on line 1087 (`let Some(liberated_sig) = typeck_results.liberated_fn_sigs().get(fn_hir_id) else { return false; };`) makes sure we're grabbing the _right_ return type for this suggestion to check the `dyn` predicates with. Fixes rust-lang#91801 Fixes rust-lang#91803 This fix also includes some drive-by changes, specifically: 1. Don't suggest boxing when we have `-> dyn Trait` and are already returning `Box<T>` where `T: Trait` (before we always boxed the value). 2. Suggestion applies even when the return type is a type alias (e.g. `type Foo = dyn Trait`). This does cause the suggestion to expand to the aliased type, but I think it's still beneficial. 3. Split up the multipart suggestion because there's a 6-line max in the printed output... I am open to splitting out the above changes, if we just want to fix the ICE first. cc: `@terrarier2111` and rust-lang#92289
Configuration menu - View commit details
-
Copy full SHA for 8baa470 - Browse repository at this point
Copy the full SHA 8baa470View commit details