Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove last vestiges of skippng ident span hashing #96016

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Remove last vestiges of skippng ident span hashing #96016

merged 1 commit into from
Apr 17, 2022

Conversation

Aaron1011
Copy link
Member

This removes a comment that no longer applies, and properly hashes
the full ident for path segments.

@Aaron1011
Remove last vestiges of skippng ident span hashing
002a4e1 
This removes a comment that no longer applies, and properly hashes
the full ident for path segments.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 13, 2022
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2022
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 13, 2022
@bors
Copy link
Contributor

bors commented Apr 13, 2022

⌛ Trying commit 002a4e1 with merge a6007f8e3f60d01d5451819b7c082c9b80b8a12a...

cjgillot
cjgillot reviewed Apr 13, 2022
View reviewed changes
compiler/rustc_ast/src/ast.rs
@@ -107,11 +107,11 @@ impl PartialEq<Symbol> for Path {
}
}

impl<CTX> HashStable<CTX> for Path {
impl<CTX: rustc_span::HashStableContext> HashStable<CTX> for Path {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this impl used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to be able to call ident.hash_stable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the impl for Path.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used by AttrItem and other AST structs

@bors
Copy link
Contributor

bors commented Apr 13, 2022

☀️ Try build successful - checks-actions
Build commit: a6007f8e3f60d01d5451819b7c082c9b80b8a12a (a6007f8e3f60d01d5451819b7c082c9b80b8a12a)

@rust-timer
Copy link
Collaborator

Queued a6007f8e3f60d01d5451819b7c082c9b80b8a12a with parent ab33f71, future comparison URL.

@davidtwco
Copy link
Member

r? @cjgillot

@rust-highfive rust-highfive assigned cjgillot and unassigned davidtwco Apr 14, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a6007f8e3f60d01d5451819b7c082c9b80b8a12a): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 2 0 0 0
mean2 N/A 1.3% N/A N/A N/A
max N/A 1.3% N/A N/A N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 14, 2022
@cjgillot
Copy link
Contributor

This PR fixes a possible incremental compilation ICE.
@bors r+
@rustbot label: +perf-regression-triaged

@bors
Copy link
Contributor

bors commented Apr 15, 2022

📌 Commit 002a4e1 has been approved by cjgillot

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Apr 15, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2022
@bors
Copy link
Contributor

bors commented Apr 17, 2022

⌛ Testing commit 002a4e1 with merge af68f71...

@bors
Copy link
Contributor

bors commented Apr 17, 2022

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing af68f71 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 17, 2022
@bors bors merged commit af68f71 into rust-lang:master Apr 17, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 17, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (af68f71): comparison url.

Summary:

  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 1 0 0 7 1
mean2 2.6% N/A N/A -0.4% 2.6%
max 2.6% N/A N/A -0.5% 2.6%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

@pnkfelix
Copy link
Member

Visiting for weekly performance triage.

  • This was already marked as triaged, but at the time it was marked, the only regressions were to secondary benchmarks.
  • The version that landed flagged a 2.6% regression to primary benchmark syn-1.0.89, which wasn't expected by the trial runs.
  • (self-profile says its due to extra time spent in LLVM).

However, the graph of syn-1.0.89 tells us a slightly different story:

image

I'm willing to chalk this up to measurement noise.

@rustbot label: +perf-regression-triaged
(again)

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Apr 21, 2022
Open
@dwrensha dwrensha mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@cjgillot cjgillot

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Aaron1011 @rust-highfive @rust-timer @bors @davidtwco @cjgillot @pnkfelix @rustbot