Move remaining tests with NLL differences to revisions

[jackh726]

Based on #97206

I've already filed issues for any important differences that I've spotted: #97252 #97253 #97256 #97267

There is a lot here, but each commit is self-contained as a separate directory. I can split into separate PRs as wanted or needed.

[rust-highfive]

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

[jackh726]

@cjgillot while this is technically blocked on #97206, each commit is independent (including from that). I decided to just use that as a base, since it modifies NLL tests. It's also already approved and in the bors queue . So, I would appreciate a review whenever you have time (I wouldn't mind just being able to just have this approved for when the other lands, for example).

[jackh726]

Note to self, need to update this once #96515 lands (https://github.com/rust-lang/rust/pull/96515/files#diff-6a6b025c2f35f56e17f04a29082743bcecc56b4ec83a27cbea3b676c9369dea6R1)

edit: done

[cjgillot]

Does this option still exist in the compiler?

[jackh726]

I'm not sure - preexisting thought and I'd rather not make this PR anything other than mechanical. (Though I should try to remember to come back to this at some point)

[cjgillot]

@jackh726 are there cases you want to draw attention to? I did not really anything stand out, the changes seem mostly mechanical.
r=me once #97206 lands

[jackh726]

Nope, no cases to draw attention to. I don't think there was anything really surprising in the nll diagnostics compared to base. Obviously, I already filed issues for the cases where we obviously are slightly worse. But there was nothing that is like "oh, that's not good".

[jackh726]

@bors r=cjgillot p=1

(bitrotty)

[bors]

📌 Commit 383fbee has been approved by cjgillot

[bors]

⌛ Testing commit 383fbee with merge 07e7b43...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 07e7b43 to master...

[rust-timer]

Finished benchmarking commit (07e7b43): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: mixed results

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	0	2	2	2	2
mean2	N/A	2.4%	-2.9%	-1.6%	-2.9%
max	N/A	3.9%	-3.4%	-1.7%	-3.4%

Cycles

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: no relevant changes found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	2	0	3	0	5
mean2	2.4%	N/A	-2.1%	N/A	-0.3%
max	2.9%	N/A	-2.5%	N/A	2.9%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. number of relevant changes ↩ ↩²

2. the arithmetic mean of the percent change ↩ ↩²