-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially stabilize const_slice_from_raw_parts #97522
Partially stabilize const_slice_from_raw_parts #97522
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? @scottmcm (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
f0bb103
to
01203df
Compare
@rfcbot merge cc @rust-lang/wg-const-eval |
Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ |
📌 Commit 08819803a89d82543261337786f19897f5761828 has been approved by It is now in the queue for this repository. |
Rebased. |
@bors r+ |
📌 Commit 96ef66a78dd52dd46ccfa3d58a171e9bf9e62be6 has been approved by It is now in the queue for this repository. |
This comment has been minimized.
This comment has been minimized.
This doesn't stabilize methods working on mutable pointers.
96ef66a
to
0753fd1
Compare
@bors r=dtolnay |
☀️ Test successful - checks-actions |
Finished benchmarking commit (95e7764): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
…mut})]` `from_raw_parts` has been partially stabilized by [rust-lang/rust#97522][1]. `from_raw_parts_mut` has been split into a separate feature `const_slice_from_raw_parts_mut`. [1]: rust-lang/rust#97522
For const std::slice::from_raw_parts, stabilized in rust-lang/rust#97522
For const std::slice::from_raw_parts, stabilized in rust-lang/rust#97522
For const std::slice::from_raw_parts, stabilized in rust-lang/rust#97522
For const std::slice::from_raw_parts, stabilized in rust-lang/rust#97522
For const std::slice::from_raw_parts, stabilized in rust-lang/rust#97522
For const std::slice::from_raw_parts, stabilized in rust-lang/rust#97522
This doesn't stabilize methods working on mutable pointers.
This pull request continues from #94946.
Pinging @rust-lang/wg-const-eval this because I use
rustc_allow_const_fn_unstable
. I believe this is justifiable as it's already possible to useslice::from_raw_parts
in stable by abusingtransmute
. The stable alternative to this would be to provide a stable const implementation ofstd::ptr::from_raw_parts
(as it can already be implemented in stable).@rustbot modify labels: +T-libs-api