Migrate some diagnostics from rustc_const_eval to SessionDiagnostic
#98657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
compiler-errors
force-pushed
the
rustc-const-eval-session-diagnostic-1
branch
from
4605a17
to
4dd984c
Compare
davidtwco
approved these changes
Jun 29, 2022
src/test/ui-fulldeps/session-diagnostic/diagnostic-derive.stderr
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
compiler-errors
force-pushed
the
rustc-const-eval-session-diagnostic-1
branch
from
4dd984c
to
2058333
Compare
|
@rustbot ready :) |
This comment was marked as resolved.
This comment was marked as resolved.
|
lmao @rustbot ready |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 8, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#98533 (Add a `-Zdump-drop-tracking-cfg` debugging flag) - rust-lang#98654 (An optimization for `pest-2.1.3`) - rust-lang#98657 (Migrate some diagnostics from `rustc_const_eval` to `SessionDiagnostic`) - rust-lang#98794 (Highlight conflicting param-env candidates) Failed merges: - rust-lang#98957 ( don't allow ZST in ScalarInt ) r? `@ghost` `@rustbot` modify labels: rollup
davidtwco
added
the
A-translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still trying to get the hang of this, so it doesn't migrate all of
rustc_const_eval. Working on that later.r? @davidtwco