-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many small deriving cleanups #98741
Merged
Merged
Many small deriving cleanups #98741
Commits on Jun 30, 2022
-
Use
split_{first,last}
incs_fold1
.It makes the code a little nicer to read.
Configuration menu - View commit details
-
Copy full SHA for 72a1621 - Browse repository at this point
Copy the full SHA 72a1621View commit details -
Remove unnecessary fields from
EnumNonMatchingCollapsed
.The `&[ast::Variant]` field isn't used. The `Vec<Ident>` field is only used for its length, but that's always the same as the length of the `&[Ident]` and so isn't necessary.
Configuration menu - View commit details
-
Copy full SHA for 7a4fdcb - Browse repository at this point
Copy the full SHA 7a4fdcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d13fa0d - Browse repository at this point
Copy the full SHA d13fa0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1254fe9 - Browse repository at this point
Copy the full SHA 1254fe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89f6917 - Browse repository at this point
Copy the full SHA 89f6917View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57d5689 - Browse repository at this point
Copy the full SHA 57d5689View commit details -
Remove some commented-out code.
This was accidentally left behind in a previous commit.
Configuration menu - View commit details
-
Copy full SHA for 623ebbe - Browse repository at this point
Copy the full SHA 623ebbeView commit details
Commits on Jul 1, 2022
-
Improve a comment, and panic on an impossible code path.
Configuration menu - View commit details
-
Copy full SHA for 78ec19f - Browse repository at this point
Copy the full SHA 78ec19fView commit details -
The existing derive code allows for various possibilities that aren't needed in practice, which complicates the code. There are only a few auto-derived traits and new ones are unlikely, so this commit simplifies things. - `PtrTy` has been eliminated. The `Raw` variant was never used, and the lifetime for the `Borrowed` variant was always `None`. That left just the mutability field, which has been inlined as necessary. - `MethodDef::explicit_self` was a confusing `Option<Option<PtrTy>>`. Indicating either `&self` or nothing. It's now a `bool`. - `borrowed_self` is renamed as `self_ref`. - `Ty::Ptr` is renamed to `Ty::Ref`.
Configuration menu - View commit details
-
Copy full SHA for b942466 - Browse repository at this point
Copy the full SHA b942466View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18fef6b - Browse repository at this point
Copy the full SHA 18fef6bView commit details -
Rename
Ty::Literal
asTy::Path
.Because a `Literal` is a type of expression, and is simply the wrong name for this.
Configuration menu - View commit details
-
Copy full SHA for 00307a5 - Browse repository at this point
Copy the full SHA 00307a5View commit details -
Because that's all that is needed in practice.
Configuration menu - View commit details
-
Copy full SHA for 85e8d94 - Browse repository at this point
Copy the full SHA 85e8d94View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.