Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable raw-dylib for bin crates #98778

Closed
wants to merge 1 commit into from
Closed

Enable raw-dylib for bin crates #98778

wants to merge 1 commit into from

Conversation

dpaoliello
Copy link
Contributor

Fixes #93842

When a raw-dylib is used in a bin crate, we need to link to the library name specified.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 1, 2022
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2022
@lcnr
Copy link
Contributor

lcnr commented Jul 4, 2022

r? rust-lang/compiler

@michaelwoerister
Copy link
Member

Thanks for the PR, @dpaoliello! Looks good to me.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 4, 2022

📌 Commit b8213bb has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 4, 2022
@JohnTitor
Rollup merge of rust-lang#98778 - dpaoliello:rawdylibbin, r=michaelwo…
6aace7f 
…erister

Enable raw-dylib for bin crates

Fixes rust-lang#93842

When a `raw-dylib` is used in a `bin` crate, we need to link to the library name specified.
@JohnTitor JohnTitor mentioned this pull request Jul 4, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 4, 2022
@Dylan-DPC
Rollup merge of rust-lang#98778 - dpaoliello:rawdylibbin, r=michaelwo…
829a718 
…erister

Enable raw-dylib for bin crates

Fixes rust-lang#93842

When a `raw-dylib` is used in a `bin` crate, we need to link to the library name specified.
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 4, 2022
Closed
@matthiaskrgr
Copy link
Member

@bors r- failed in a rollup
#98899 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 4, 2022
@dpaoliello
Copy link
Contributor Author

This is the incorrect fix: I need to dig into this more and will provide a new PR once I have the correct fix.

@dpaoliello dpaoliello closed this Jul 5, 2022
@dpaoliello
Copy link
Contributor Author

New PR: !98989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE on #[link(..., kind = "raw-dylib")]
7 participants
@dpaoliello @rust-highfive @lcnr @michaelwoerister @bors @matthiaskrgr @rustbot