Prefer suggestion paths that are not #[doc(hidden)]

[compiler-errors]

This is a revival of #87349

Maybe we don't even need to make it this complicated? I guess I could also just insert children that have doc_hidden parents using the same fallback_map I added a while back to filter out use ... as _; imports.

[rust-highfive]

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

[compiler-errors]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 1b420a5 with merge d39a7f4152616d7b23d84acc0de1fecfc408585d...

[compiler-errors]

(cc @In-line, I can also close this if you'd rather author this PR yourself. Just doing a diagnostics-related issue triage and I saw that PR got closed, and I think it's worthwhile to land!)

[In-line]

I was planning to return to it, in some point. I don't care about who is author. If you have time to fix it, feel free to do it!

[bors]

☀️ Try build successful - checks-actions
Build commit: d39a7f4152616d7b23d84acc0de1fecfc408585d (d39a7f4152616d7b23d84acc0de1fecfc408585d)

[rust-timer]

Queued d39a7f4152616d7b23d84acc0de1fecfc408585d with parent a5c6a48, future comparison URL.

[jyn514]

Hmm, if rustc is going to add this logic I wonder if it can be shared with the existing code in

rust/src/librustdoc/visit_ast.rs

Line 51 in e1d1848

pub(crate) fn inherits_doc_hidden(tcx: TyCtxt<'_>, mut node: hir::HirId) -> bool {

[rust-timer]

Finished benchmarking commit (d39a7f4152616d7b23d84acc0de1fecfc408585d): comparison url.

Instruction count

• Primary benchmarks: 😿 relevant regressions found
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	0.5%	0.9%	22
Regressions 😿 (secondary)	1.5%	6.3%	19
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	0.5%	0.9%	22

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.8%	-3.2%	2
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

• Primary benchmarks: 😿 relevant regressions found
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	4.3%	4.9%	2
Regressions 😿 (secondary)	4.0%	7.6%	8
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	4.3%	4.9%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[compiler-errors]

@rustbot author