Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't allow ZST in ScalarInt #98957

Merged
merged 4 commits into from
Jul 9, 2022
Merged

don't allow ZST in ScalarInt #98957

merged 4 commits into from
Jul 9, 2022

Commits on Jul 9, 2022

  1. don't allow ZST in ScalarInt 

    There are several indications that we should not ZST as a ScalarInt:
- We had two ways to have ZST valtrees, either an empty `Branch` or a `Leaf` with a ZST in it.
  `ValTree::zst()` used the former, but the latter could possibly arise as well.
- Likewise, the interpreter had `Immediate::Uninit` and `Immediate::Scalar(Scalar::ZST)`.
- LLVM codegen already had to special-case ZST ScalarInt.

So instead add new ZST variants to those types that did not have other variants
which could be used for this purpose.
    @RalfJung
    RalfJung committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    a422b42 View commit details
    Browse the repository at this point in the history

  2. fix cranelift and gcc backends

    @RalfJung
    RalfJung committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    052651d View commit details
    Browse the repository at this point in the history

  3. review feedback

    @RalfJung
    RalfJung committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    ac265cd View commit details
    Browse the repository at this point in the history

  4. tweak names and output and bless

    @RalfJung
    RalfJung committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    4e7aaf1 View commit details
    Browse the repository at this point in the history