Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert Scalar sanity #98968

Merged
merged 2 commits into from
Jul 6, 2022
Merged

assert Scalar sanity #98968

merged 2 commits into from
Jul 6, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 6, 2022

With #96814 having landed, finally our Scalar layouts have the invariants they deserve. :)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 6, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 6, 2022

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 6, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Jul 6, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jul 6, 2022

📌 Commit 2a1a718 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 6, 2022
Merged
@petrochenkov petrochenkov assigned oli-obk and unassigned petrochenkov Jul 6, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 6, 2022
@bors
Auto merge of rust-lang#98970 - Dylan-DPC:rollup-j0od37w, r=Dylan-DPC
049308c 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#98881 (Only compute DefKind through the query.)
 - rust-lang#98884 (macros: `LintDiagnostic` derive)
 - rust-lang#98964 (fix typo in function name)
 - rust-lang#98967 (fix typo in note about multiple inaccessible type aliases)
 - rust-lang#98968 (assert Scalar sanity)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7f62a71 into rust-lang:master Jul 6, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 6, 2022
@RalfJung RalfJung deleted the scalar-sanity branch July 8, 2022 00:51
@cuviper cuviper mentioned this pull request Jul 28, 2022
Closed
@RalfJung RalfJung mentioned this pull request Aug 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @rustbot @rust-highfive @oli-obk @bors @petrochenkov