perf check: inline valtree constructors

[RalfJung]

Let's see if this helps with the perf regression from #98957.

r? @oli-obk

[RalfJung]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 0889c9d with merge fd25cb153abc1779e4f4b6ab14250aa607919e5a...

[bors]

☀️ Try build successful - checks-actions
Build commit: fd25cb153abc1779e4f4b6ab14250aa607919e5a (fd25cb153abc1779e4f4b6ab14250aa607919e5a)

[rust-timer]

Queued fd25cb153abc1779e4f4b6ab14250aa607919e5a with parent 38b7215, future comparison URL.

[rust-timer]

Finished benchmarking commit (fd25cb153abc1779e4f4b6ab14250aa607919e5a): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.8%	2.8%	1
Improvements 🎉 (primary)	-3.0%	-3.0%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-3.0%	-3.0%	1

Cycles

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-7.6%	-7.6%	1
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[RalfJung]

Nope, what wasn't it. 🤷

@rust-lang/wg-compiler-performance are the Max RSS benchmarks very noisy? I don't see how this change can have those RSS impacts.

[Kobzol]

Yes, they are quite noisy indeed. Usually if only 1-2 benchmarks are changed, that's noise. Real changes usually materialize as a large number of changes across the board.