Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more docs regarding ideographic numbers #99626

Closed

Conversation

vincenzopalazzo
Copy link
Member

This was discussed in the last lib meeting and I try to avoid foget to open a PR because I think having some docs can help people.

However, I think we need to discuss a little bit if this is enough or if we need to add more clarification? Maybe an example?

Inspiration Source: #84056 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Jul 22, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 22, 2022
@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2022
@ChrisDenton
Copy link
Member

My feeling is that we should also push people towards is_ascii_digit and is_digit early in the documentation so it shows up in IDE hover text. This function is very very niche, so we want to make it as clear as possible that they should consider alternatives first.

@vincenzopalazzo
Copy link
Member Author

Sorry @ChrisDenton I force pushed an empty commit and the PR got closed, I insert your suggestion here #99628 because I have your same feeling that in the docs there was something missing on "Yes this function does not support ideographic numbers but how I can solve it"

Thanks

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 28, 2022
…c, r=joshtriplett

add more docs regarding ideographic numbers

This was discussed in the last lib meeting and I try to avoid forgetting to open a PR because I think having some docs can help people.

However, I think we need to discuss a little bit if this is enough or if we need to add more clarification? Maybe an example?

Inspiration Source: rust-lang#84056 (comment)

Including suggestion rust-lang#99626 (comment) my bad command git close the PR
workingjubilee pushed a commit to tcdi/postgrestd that referenced this pull request Sep 15, 2022
…triplett

add more docs regarding ideographic numbers

This was discussed in the last lib meeting and I try to avoid forgetting to open a PR because I think having some docs can help people.

However, I think we need to discuss a little bit if this is enough or if we need to add more clarification? Maybe an example?

Inspiration Source: rust-lang/rust#84056 (comment)

Including suggestion rust-lang/rust#99626 (comment) my bad command git close the PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants