-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more docs regarding ideographic numbers #99626
add more docs regarding ideographic numbers #99626
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
My feeling is that we should also push people towards |
a9e9d54
to
ffa7733
Compare
Sorry @ChrisDenton I force pushed an empty commit and the PR got closed, I insert your suggestion here #99628 because I have your same feeling that in the docs there was something missing on "Yes this function does not support ideographic numbers but how I can solve it" Thanks |
…c, r=joshtriplett add more docs regarding ideographic numbers This was discussed in the last lib meeting and I try to avoid forgetting to open a PR because I think having some docs can help people. However, I think we need to discuss a little bit if this is enough or if we need to add more clarification? Maybe an example? Inspiration Source: rust-lang#84056 (comment) Including suggestion rust-lang#99626 (comment) my bad command git close the PR
…triplett add more docs regarding ideographic numbers This was discussed in the last lib meeting and I try to avoid forgetting to open a PR because I think having some docs can help people. However, I think we need to discuss a little bit if this is enough or if we need to add more clarification? Maybe an example? Inspiration Source: rust-lang/rust#84056 (comment) Including suggestion rust-lang/rust#99626 (comment) my bad command git close the PR
This was discussed in the last lib meeting and I try to avoid foget to open a PR because I think having some docs can help people.
However, I think we need to discuss a little bit if this is enough or if we need to add more clarification? Maybe an example?
Inspiration Source: #84056 (comment)