Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't build std for *-uefi targets #99765

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Don't build std for *-uefi targets #99765

merged 1 commit into from
Jul 27, 2022

Conversation

nicholasbishop
Copy link
Contributor

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 26, 2022
@rust-highfive
Copy link
Collaborator

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 26, 2022

@bors r+ rollup

We should probably find a better long term solution, like the issue mentioned ... but this is fine for now.

@bors
Copy link
Contributor

bors commented Jul 26, 2022

📌 Commit 05c1a4a has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 26, 2022
@matthiaskrgr
Rollup merge of rust-lang#99765 - nicholasbishop:bishop-disable-uefi-…
09eac4e 
…std-build, r=jyn514

Don't build std for *-uefi targets

rust-lang#97322
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 26, 2022
Closed
@JohnTitor JohnTitor mentioned this pull request Jul 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 27, 2022
@bors
Auto merge of rust-lang#99792 - JohnTitor:rollup-20i7ewx, r=JohnTitor
e33cc71 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#98583 (Stabilize Windows `FileTypeExt` with `is_symlink_dir` and `is_symlink_file`)
 - rust-lang#99698 (Prefer visibility map parents that are not `doc(hidden)` first)
 - rust-lang#99700 (Add a clickable link to the layout section)
 - rust-lang#99712 (passes: port more of `check_attr` module)
 - rust-lang#99759 (Remove dead code from cg_llvm)
 - rust-lang#99765 (Don't build std for *-uefi targets)
 - rust-lang#99771 (Update pulldown-cmark version to 0.9.2 (fixes url encoding for some chars))
 - rust-lang#99775 (rustdoc: do not allocate String when writing path full name)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a76f2fe into rust-lang:master Jul 27, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 27, 2022
@nicholasbishop nicholasbishop deleted the bishop-disable-uefi-std-build branch July 28, 2022 01:37
@Ayush1325 Ayush1325 mentioned this pull request Nov 4, 2022
Closed
@workingjubilee workingjubilee added the O-UEFI UEFI label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
O-UEFI UEFI S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nicholasbishop @rust-highfive @jyn514 @bors @workingjubilee @rustbot