Fix PermissionDenied UI tests on WSL #99807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If appendWindowsPath is set to true (the default IIRC), running invalid commands returns PermissionDenied instead of NotFound.
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Noratrieb
force-pushed
the
wsl-ui-test-fix
branch
2 times, most recently
from
38d1b89
to
29e0851
Compare
It checked for a "not found", but on WSL with appendWindowsPath=true, PermissionDenied is the error instead.
Noratrieb
force-pushed
the
wsl-ui-test-fix
branch
from
29e0851
to
62ad16f
Compare
|
This seems OK. My guess is that the permission denied might actually be a result of attempts to execute files in Windows (and your WSL environment doesn't have the right permissions to do so), rather than a blanket permission denied, but in any case seems easy enough to hit it. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 28, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#99628 (add more docs regarding ideographic numbers) - rust-lang#99689 (Revert `write!` and `writeln!` to late drop temporaries) - rust-lang#99807 (Fix PermissionDenied UI tests on WSL) - rust-lang#99817 (rustdoc: remove Clean trait impls for more items) - rust-lang#99851 (Fix small typo in Cargo.toml comment) - rust-lang#99856 (fix: remove fake no_dead_strip for osx) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my WSL with
appendWindowsPath=true, running an invalid command returnsPermissionDeniedinstead ofNotFound, causing two UI tests to fail.