Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LICENSE files in the published rustc-demangle-capi crate #72

Open
danakj opened this issue Sep 24, 2024 · 0 comments · May be fixed by #73
Open

Include LICENSE files in the published rustc-demangle-capi crate #72

danakj opened this issue Sep 24, 2024 · 0 comments · May be fixed by #73

Comments

@danakj
Copy link

danakj commented Sep 24, 2024

While the Cargo.toml specifies a license (or licenses), crates also typically include a copy of that license (or licenses) as LICENSE files. This github repo contains the license files but the rustc-demangle-capi crate does not.

FWIW the rustc-demangle crate does include the license files. Can they also be included in the rustc-demangle-capi crate?

As a consumer of third party open source libraries, Chromium is aiming to ensure we include the license files in our own source tree for all of our third-party dependencies, and the rustc-demangle-capi crate is one of a few for which they are missing. Chromium issue: crbug.com/369075726

danakj added a commit to danakj/rustc-demangle that referenced this issue Sep 25, 2024
This ensures projects that include the source code for this project
will also get a copy of the licenses.

Fixes rust-lang#72.
@danakj danakj linked a pull request Sep 25, 2024 that will close this issue
danakj added a commit to danakj/rustc-demangle that referenced this issue Sep 25, 2024
Symlinks are added up to the license files in the repository
root.

This ensures projects that include the source code for this project
will also get a copy of the licenses.

Fixes rust-lang#72.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant