Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly write to output instead of local String buffer #63

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Directly write to output instead of local String buffer #63

merged 1 commit into from
Apr 5, 2023

Commits on Apr 1, 2023

  1. Directly write to output instead of local String buffer 

    Previous measurements showed this to be a net loss in performance, but
further investigation shows that is likely to be a result of increased
syscalls in the test benchmark. Adjusting the benchmark to buffer the
output (e.g., with std::io::BufWriter) makes this a win, around 16%
faster.

Documentation on demangle_stream is updated to recommend buffering the
output writer.
    @Mark-Simulacrum
    Mark-Simulacrum committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    13be70d View commit details
    Browse the repository at this point in the history