Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace experts map with reviewers from triagebot #1831

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Replace experts map with reviewers from triagebot #1831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/compiler-team.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ Currently the compiler team chats in Zulip:
with rustc development, or [`t-compiler/meetings`][zulip-meetings],
where the team holds their weekly triage and steering meetings.

## Expert map
## Reviewers

If you're interested in figuring out who can answer questions about a
particular part of the compiler, or you'd just like to know who works on what,
check out our [experts directory][experts].
check out [triagebot.toml's assign section][map].
It contains a listing of the various parts of the compiler and a list of people
who are experts on each one.
who are reviewers of each part.

[experts]: https://github.com/rust-lang/compiler-team/blob/master/content/experts/map.toml
[map]: https://github.com/rust-lang/rust/blob/master/triagebot.toml

## Rust compiler meeting

Expand Down
13 changes: 6 additions & 7 deletions src/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,20 +47,19 @@ guide :)

### Experts

Not all `t-compiler` members are experts on all parts of `rustc`; it's a pretty
large project. To find out who has expertise on different parts of the
compiler, [consult this "experts map"][map].

The experts map incomplete and not actively maintained, so please also feel free to ask questions
even if you can't figure out who to ping.
Not all `t-compiler` members are experts on all parts of `rustc`; it's a
pretty large project. To find out who could have some expertise on
different parts of the compiler, [consult traigebot assign groups][map].
The sections that start with `[assign*` in `triagebot.toml` file.
But also, feel free to ask questions even if you can't figure out who to ping.

Another way to find experts for a given part of the compiler is to see who has made recent commits.
For example, to find people who have recently worked on name resolution since the 1.68.2 release,
you could run `git shortlog -n 1.68.2.. compiler/rustc_resolve/`. Ignore any commits starting with
"Rollup merge" or commits by `@bors` (see [CI contribution procedures](./contributing.md#ci) for
more information about these commits).

[map]: https://github.com/rust-lang/compiler-team/blob/master/content/experts/map.toml
[map]: https://github.com/rust-lang/rust/blob/master/triagebot.toml

### Etiquette

Expand Down