Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BodyId description #302

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Update BodyId description #302

merged 1 commit into from
Apr 20, 2019

Conversation

rasendubi
Copy link
Contributor

It is now a newtype'd HirId, not NodeId.

See rust-lang/rust#58167.

@rasendubi
Update BodyId description
a6acffd 
It is now a newtype'd HirId, not NodeId.

See rust-lang/rust#58167.
mark-i-m
mark-i-m approved these changes Apr 20, 2019
View reviewed changes
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! This is very helpful and welcome, so thanks for the last few PRs.

@mark-i-m mark-i-m merged commit 99e1b1d into rust-lang:master Apr 20, 2019
@rasendubi
Copy link
Contributor Author

No problem! I'm just following the guide for the last few days and fixing things along the way ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-i-m mark-i-m mark-i-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rasendubi @mark-i-m