Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.0.0 and add changelog #44

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

Noratrieb
Copy link
Member

This adds a changelog for all the changes in 1.2.0 and 1.3.0 and then bumps the version to 1.3.0 for the next release.

I chose a minor version, but there is an argument to be made for this being a major version, as the crate does document that it's fxhash. But given that the fxhash output is not really stable and differs between platforms anyways, I think it makes sense to say that the precise numbers were never guaranteed to be stable, and that this is therefore a minor release.

CHANGELOG.md Outdated Show resolved Hide resolved
@nnethercote
Copy link
Contributor

I would argue for calling it 2.0. After all, it's a completely different algorithm! If that doesn't qualify for a version 2.0 (in the colloquial sense) then nothing will...

@nnethercote
Copy link
Contributor

Otherwise, looks ok to me.

Adds changelog entries for the new 1.3.0 release and also for the
previous 1.2.0 release. I did not bother documenting previous releases.
@Noratrieb
Copy link
Member Author

fair, I'll change it to 2.0.0

Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although as I said: I wish we published 1.3.0 with fxhash first (but ultimately it doesn't matter)

and also includes a signficantly better string hasher.
- Fix `no_std` builds

## 1.2.0 (**YANKED**)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kinda sad that we don't have fxhash version of this crate with the improvements of 1.2.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think it matters much, people who are already using it don't benefit much from the changes, while new users will get 2.0.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the things on the changelog were long awaited, so I'm not sure people who already use it won't benefit from this.

@WaffleLapkin WaffleLapkin changed the title Bump version to 1.3.0 and add changelog Bump version to 2.0.0 and add changelog Jun 3, 2024
@Amanieu
Copy link
Member

Amanieu commented Jun 17, 2024

Ping! I'd like to switch hashbrown to use fxhash by default once the new algorithm is released.

README.md Outdated Show resolved Hide resolved
@Noratrieb Noratrieb merged commit 8f258ee into rust-lang:master Jun 18, 2024
3 checks passed
@Noratrieb Noratrieb deleted the release13 branch June 18, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants