Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PR rollup table formatting #1623

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 25, 2023

The context is described in the linked issue. The last commit isn't mentioned in the issue, but it's something that has bothered me :)

Fixes: #1622

This is how it should look like (simulated, as this is not straightforward to test):
image

Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you.

I'm not sure what changing the branch comment entails, but that seems fine.

site/src/github.rs Outdated Show resolved Hide resolved
This makes sure that they will be ordered in the same way as in the rollup PR description.
This makes it easier to understand which PR the unrolled build belongs to.
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 26, 2023

Let's check if this works in the wild.

@Kobzol Kobzol merged commit 8835ef0 into rust-lang:master Jun 26, 2023
@Kobzol Kobzol deleted the rollup-table branch June 26, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve rust-timer rollup messages
2 participants