-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove comments in extern #4528
Labels
bug
Panic, non-idempotency, invalid code, etc.
Comments
Thanks for the report @giraffate, see the problem and will try to get the fix out to nightly ASAP |
This was referenced Nov 17, 2020
It only remove multi line comments. Single line comments are preserved. |
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this issue
Nov 17, 2020
…ark-Simulacrum update rustfmt to v1.4.27 Fixes rust-lang/rustfmt#4528
berkus
added a commit
to metta-systems/vesper
that referenced
this issue
Nov 17, 2020
See rust-lang/rustfmt#4528 for the bug description, namely rustfmt removes this comment completely if it's left in the extern block.
Closing as this is resolved in v1.4.27 available in the latest nightly (2020-11-18) |
giraffate
added a commit
to giraffate/rust-clippy
that referenced
this issue
Nov 19, 2020
This reverts commit 0e80341. Fixed by rust-lang/rustfmt#4528.
bors
added a commit
to rust-lang/rust-clippy
that referenced
this issue
Nov 19, 2020
Revert "Add `rustfmt::skip` as a work around" This reverts commit 0e80341. Fixed by rustfmt v1.4.27 available in the latest nightly (2020-11-18). Refer to rust-lang/rustfmt#4528. changelog: none
berkus
added a commit
to metta-systems/vesper
that referenced
this issue
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
rustfmt removes comments in extern. This seems to be introduced since v1.4.26. I found this in clippy CI https://github.com/rust-lang/rust-clippy/pull/6336/checks?check_run_id=1404315427 in PR rust-lang/rust-clippy#6336.
To Reproduce
Expected behavior
not to remove comments
Meta
The text was updated successfully, but these errors were encountered: