Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate rustfmt into multiple crates #2419

Merged
merged 9 commits into from
Feb 11, 2018
Merged

Conversation

topecongiro
Copy link
Contributor

cc #1583.
Now the directory looks like as follows (a tree of tests directory is omitted):

.
├── CHANGELOG.md
├── Cargo.lock
├── Cargo.toml
├── Configurations.md
├── Contributing.md
├── Design.md
├── LICENSE-APACHE
├── LICENSE-MIT
├── README.md
├── appveyor.yml
├── atom.md
├── bootstrap.sh
├── build.rs
├── cargo-fmt
│   ├── Cargo.toml
│   └── src
│       └── main.rs
├── git-rustfmt
│   ├── Cargo.toml
│   └── src
│       └── main.rs
├── legacy-rustfmt.toml
├── rustfmt-bin
│   ├── Cargo.toml
│   ├── build.rs
│   └── src
│       └── main.rs
├── rustfmt-config
│   ├── Cargo.toml
│   └── src
│       ├── config_type.rs
│       ├── file_lines.rs
│       ├── lib.rs
│       ├── lists.rs
│       ├── macros.rs
│       ├── options.rs
│       └── summary.rs
├── rustfmt-core
│   ├── Cargo.toml
│   ├── src
│   │   ├── chains.rs
│   │   ├── checkstyle.rs
│   │   ├── closures.rs
│   │   ├── codemap.rs
│   │   ├── comment.rs
│   │   ├── expr.rs
│   │   ├── filemap.rs
│   │   ├── imports.rs
│   │   ├── issues.rs
│   │   ├── items.rs
│   │   ├── lib.rs
│   │   ├── lists.rs
│   │   ├── macros.rs
│   │   ├── missed_spans.rs
│   │   ├── modules.rs
│   │   ├── patterns.rs
│   │   ├── rewrite.rs
│   │   ├── rustfmt_diff.rs
│   │   ├── shape.rs
│   │   ├── spanned.rs
│   │   ├── string.rs
│   │   ├── types.rs
│   │   ├── utils.rs
│   │   ├── vertical.rs
│   │   └── visitor.rs
│   └── tests
└── rustfmt-format-diff
    ├── Cargo.toml
    └── src
        ├── main.rs
        └── test
            └── bindgen.diff

@nrc
Copy link
Member

nrc commented Feb 11, 2018

Awesome, thank you!

@nrc nrc merged commit 8f8ee9e into rust-lang:master Feb 11, 2018
davidalber added a commit to davidalber/rustfmt that referenced this pull request Feb 12, 2018
Issue rust-lang#2419 changed the directory in which
`configuration_snippet_tests` runs, which broke the test. Since the
test is currently annotated with `#[ignore]`, the break wasn't
caught before merge.
nrc added a commit that referenced this pull request Mar 2, 2018
@topecongiro topecongiro deleted the core branch July 21, 2019 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants