Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract configuration snippet tests into own module #3667

Merged
merged 2 commits into from
Jul 14, 2019
Merged

Extract configuration snippet tests into own module #3667

merged 2 commits into from
Jul 14, 2019

Conversation

bash
Copy link

@bash bash commented Jul 3, 2019

No description provided.

scampi
scampi approved these changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@scampi scampi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @topecongiro you ok with the changes ?

@topecongiro
Copy link
Contributor

LGTM, thanks!

@topecongiro topecongiro merged commit 37695b3 into rust-lang:master Jul 14, 2019
@bash bash deleted the extract-configuration-snippet-tests branch July 14, 2019 13:27
@scampi scampi mentioned this pull request Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scampi scampi scampi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bash @topecongiro @scampi