Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate --backup option #3902

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

calebcartwright
Copy link
Member

@calebcartwright calebcartwright commented Nov 3, 2019

Refs #3887

As this was an internal/non-user facing option I didn't think there were any other changes needed in the config module as part of this deprecation, but please let me know if I missed anything

@topecongiro
Copy link
Contributor

Sorry that the original issue was unclear about my intention, but I would prefer to remove this and make it a hard error rather than keep it.

@calebcartwright
Copy link
Member Author

Sorry that the original issue was unclear about my intention, but I would prefer to remove this and make it a hard error rather than keep it.

No worries! Will update this accordingly

@topecongiro topecongiro merged commit 7ecd467 into rust-lang:master Nov 12, 2019
@topecongiro
Copy link
Contributor

Thanks!

@calebcartwright calebcartwright deleted the deprecate-backup branch November 12, 2019 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants