Remove report_todo and report_fixme #4129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
approved these changes
Apr 19, 2020
There was a problem hiding this comment.
I was always a little confused why rustfmt had this capability anyway, and also worth noting that the detection is buggy as well (it reports any occurrence of that sequence of characters, even if that sequence is for example an ident).
I suspect there will be a small group of folks that'll be disappointed to see this feature go, but I agree that it'd be best to remove it from rustfmt and defer to other tools to provide that capability 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
report_todoandreport_fixmeconfiguration options. These were added a long time ago when the rustfmt development was at the experimental stage and kind of being forgotten since then. I think that these are outside the scope of formatter and that we can replace them with other tools likerg.Close #3393. Close #3394.