Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve polarity on negative non-trait impl #4567

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Preserve polarity on negative non-trait impl #4567

merged 2 commits into from
Dec 1, 2020

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Dec 1, 2020

Fixes #4566.

calebcartwright
calebcartwright approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@calebcartwright calebcartwright merged commit 4fabb31 into rust-lang:master Dec 1, 2020
@dtolnay dtolnay deleted the negative-impl branch December 1, 2020 04:20
@dtolnay dtolnay mentioned this pull request Dec 1, 2020
Merged
@karyon
Copy link
Contributor

karyon commented Oct 26, 2021

backported in #4568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
1x-backport:completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rustfmt deletes polarity of negative impl
3 participants
@dtolnay @karyon @calebcartwright