Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating outdated links #4869

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Updating outdated links #4869

merged 3 commits into from
Jun 16, 2021

Conversation

murchu27
Copy link
Contributor

@murchu27 murchu27 commented Jun 14, 2021

Updating the links to the docs and source code for ast.rs. Seems like it was moved to a new crate at some point.

EDIT: also updating some links in the README (comment below)

Updating the links to the docs and source code for `ast.rs`. Seems like it was moved to a new crate at some point.
This time, the links to the `fmt-rfcs` repository, which is now owned by
`rust-dev-tools` (although GitHub was redirecting anyway).
@murchu27
Copy link
Contributor Author

Pushed 31b789d to update some links in the README, too. Specifically the links to the fmt-rfcs reposiory, which appears to have changed owner

Contributing.md Outdated Show resolved Hide resolved
Co-authored-by: Caleb Cartwright <[email protected]>
@murchu27
Copy link
Contributor Author

@calebcartwright you mention in a comment on another PR that you want to avoid merge commits.

it'd be best to submit the pulls from feature branches that have are up to date/rebased against the trunk branch here

Do the changes in this PR allow for this? Or do I need to change anything?

@calebcartwright
Copy link
Member

@calebcartwright you mention in a comment on another PR that you want to avoid merge commits.

it'd be best to submit the pulls from feature branches that have are up to date/rebased against the trunk branch here

Do the changes in this PR allow for this? Or do I need to change anything?

This is fine, thanks for asking though! It's primarily about how your source branch for the PR is updated, when necessary, and doing so by rebasing.

I can always squash all the commits as part of landing a PR, but there are times when it's helpful to maintain the individual commits which isn't an option if the PR source branch has merge commits. (related note, going to squash these as we don't need 3 commits for a 4 line diff)

@calebcartwright calebcartwright merged commit 6495024 into rust-lang:master Jun 16, 2021
@murchu27 murchu27 deleted the patch-1 branch June 16, 2021 06:07
calebcartwright added a commit to calebcartwright/rustfmt that referenced this pull request Jul 26, 2021
* Updating outdated links

Updating the links to the docs and source code for `ast.rs`. Seems like it was moved to a new crate at some point.

* Updating more outdated links

This time, the links to the `fmt-rfcs` repository, which is now owned by
`rust-dev-tools` (although GitHub was redirecting anyway).

* Update Contributing.md

Co-authored-by: Caleb Cartwright <[email protected]>

Co-authored-by: Caleb Cartwright <[email protected]>
calebcartwright added a commit that referenced this pull request Jul 26, 2021
* Updating outdated links

Updating the links to the docs and source code for `ast.rs`. Seems like it was moved to a new crate at some point.

* Updating more outdated links

This time, the links to the `fmt-rfcs` repository, which is now owned by
`rust-dev-tools` (although GitHub was redirecting anyway).

* Update Contributing.md

Co-authored-by: Caleb Cartwright <[email protected]>

Co-authored-by: Caleb Cartwright <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants