-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating outdated links #4869
Updating outdated links #4869
Conversation
Updating the links to the docs and source code for `ast.rs`. Seems like it was moved to a new crate at some point.
This time, the links to the `fmt-rfcs` repository, which is now owned by `rust-dev-tools` (although GitHub was redirecting anyway).
Pushed 31b789d to update some links in the README, too. Specifically the links to the |
Co-authored-by: Caleb Cartwright <[email protected]>
@calebcartwright you mention in a comment on another PR that you want to avoid merge commits.
Do the changes in this PR allow for this? Or do I need to change anything? |
This is fine, thanks for asking though! It's primarily about how your source branch for the PR is updated, when necessary, and doing so by rebasing. I can always squash all the commits as part of landing a PR, but there are times when it's helpful to maintain the individual commits which isn't an option if the PR source branch has merge commits. (related note, going to squash these as we don't need 3 commits for a 4 line diff) |
* Updating outdated links Updating the links to the docs and source code for `ast.rs`. Seems like it was moved to a new crate at some point. * Updating more outdated links This time, the links to the `fmt-rfcs` repository, which is now owned by `rust-dev-tools` (although GitHub was redirecting anyway). * Update Contributing.md Co-authored-by: Caleb Cartwright <[email protected]> Co-authored-by: Caleb Cartwright <[email protected]>
* Updating outdated links Updating the links to the docs and source code for `ast.rs`. Seems like it was moved to a new crate at some point. * Updating more outdated links This time, the links to the `fmt-rfcs` repository, which is now owned by `rust-dev-tools` (although GitHub was redirecting anyway). * Update Contributing.md Co-authored-by: Caleb Cartwright <[email protected]> Co-authored-by: Caleb Cartwright <[email protected]>
Updating the links to the docs and source code for
ast.rs
. Seems like it was moved to a new crate at some point.EDIT: also updating some links in the README (comment below)