Fix #5489 - allow CONST and macrro metavariable as attribute value #5518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5489
Suggested fix for #5489 - allow macro
metavariableas attribute value. In addition, allow alsoCONSTas attribute value. The suggested fix is actually a workaround to a preferred fix ofAttribute:meta()that current is not supporting these types as attribute value.The fix handles attribute values assignments of the following forms:
#[$name]in macro or#[CONST]#[id(att1 = $name, attr2 = CONST, ...)]It may be that not all the possible cases are covered, but hopefully at least most of the practically used cases are covered.
Note that
tests/target/macro_rules.rswas modified, as#[doc=$docs]is now properly formatted to#[doc = $docs].