Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix watch command path execution #134

Merged
merged 1 commit into from
Apr 3, 2019
Merged

fix watch command path execution #134

merged 1 commit into from
Apr 3, 2019

Conversation

komaeda
Copy link
Contributor

@komaeda komaeda commented Mar 27, 2019 •
edited
Loading

@Hades32 @guttume could you test whether this works on windows by checking out the branch locally and running cargo run watch?

@guttume
Copy link

guttume commented Mar 31, 2019

@komaeda I tried this branch also but it still sits on blank line when I make changes to my code. Including screenshot.
cmd
powershell

@sebsebmc sebsebmc mentioned this pull request Mar 31, 2019
Closed
@komaeda
Copy link
Contributor Author

komaeda commented Apr 2, 2019

@bors try

bors added a commit that referenced this pull request Apr 2, 2019
@bors
Auto merge of #134 - rust-lang:fix/windows-paths, r=<try>
b0cf9a4 
fix watch command path execution

closes #126

@Hades32 @guttume could you test whether this works on windows by checking out the branch locally and running `cargo run watch`?
@bors
Copy link
Contributor

bors commented Apr 2, 2019

⌛ Trying commit 0229211 with merge b0cf9a4...

@bors
Copy link
Contributor

bors commented Apr 2, 2019

☀️ Try build successful - checks-travis
Build commit: b0cf9a4

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 2, 2019

☀️ Try build successful - checks-travis
Build commit: b0cf9a4

@komaeda
Copy link
Contributor Author

komaeda commented Apr 3, 2019

well, this still seems to fix something, so i'll merge it

@bors r+

@bors
Copy link
Contributor

bors commented Apr 3, 2019

📌 Commit 0229211 has been approved by komaeda

@bors
Copy link
Contributor

bors commented Apr 3, 2019

⌛ Testing commit 0229211 with merge fbd0ccb...

bors added a commit that referenced this pull request Apr 3, 2019
@bors
Auto merge of #134 - rust-lang:fix/windows-paths, r=komaeda
fbd0ccb 
fix watch command path execution

@Hades32 @guttume could you test whether this works on windows by checking out the branch locally and running `cargo run watch`?
@bors
Copy link
Contributor

bors commented Apr 3, 2019

☀️ Test successful - checks-travis
Approved by: komaeda
Pushing fbd0ccb to master...

@bors bors merged commit 0229211 into master Apr 3, 2019
MrDaar pushed a commit to MrDaar/rustlings that referenced this pull request Oct 30, 2019
@bors
Auto merge of rust-lang#134 - rust-lang:fix/windows-paths, r=<try>
6664052 
fix watch command path execution

closes rust-lang#126

@Hades32 @guttume could you test whether this works on windows by checking out the branch locally and running `cargo run watch`?
pedantic79 pushed a commit to pedantic79/rustlings that referenced this pull request Apr 11, 2020
@bors
Auto merge of rust-lang#134 - rust-lang:fix/windows-paths, r=komaeda
03d663e 
fix watch command path execution

@Hades32 @guttume could you test whether this works on windows by checking out the branch locally and running `cargo run watch`?
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
Auto merge of rust-lang#134 - rust-lang:fix/windows-paths, r=komaeda
54e40fd 
fix watch command path execution

@Hades32 @guttume could you test whether this works on windows by checking out the branch locally and running `cargo run watch`?
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
@bors
Auto merge of rust-lang#134 - rust-lang:fix/windows-paths, r=komaeda
96ecdfa 
fix watch command path execution

@Hades32 @guttume could you test whether this works on windows by checking out the branch locally and running `cargo run watch`?
@mo8it mo8it deleted the fix/windows-paths branch April 4, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@komaeda @guttume @bors