fix(using_as): Add test so that proper type is returned. #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanpcmcquen
changed the title
using_as so that proper type is returned.
|
Hi @ryanpcmcquen thanks for this PR. This is very much needed for the exercise! @fmoko, should be good to go. Best, |
shadows-withal
changed the title
using_as so that proper type is returned.
OnunPereira
pushed a commit
to OnunPereira/rustlings
that referenced
this pull request
Sep 30, 2020
palako
pushed a commit
to palako/rustlings
that referenced
this pull request
Nov 8, 2020
JuniousY
pushed a commit
to JuniousY/rustlings
that referenced
this pull request
Jan 28, 2021
noiffion
pushed a commit
to noiffion/rustlings
that referenced
this pull request
Aug 20, 2021
bugaolengdeyuxiaoer
pushed a commit
to bugaolengdeyuxiaoer/rustlings
that referenced
this pull request
Dec 28, 2021
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
Spacebody
pushed a commit
to Spacebody/my-rustlings
that referenced
this pull request
Nov 18, 2022
lziegler
pushed a commit
to lziegler/rustlings
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was pretty easy (at least for me), to get this to compile but return an incorrect value. I've added a test to ensure the proper type is used.
Using a
usizecast:Using
f64:Seems like the test is helpful to avoid that.