Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup download-related code in the rustup_dist crate #1131

Merged
merged 3 commits into from
May 23, 2017
Merged

Cleanup download-related code in the rustup_dist crate #1131

merged 3 commits into from
May 23, 2017

Commits on May 22, 2017

  1. Remove unused download module from rustup-dist 

    The actual code for handling downloads for rustup-dist is
in `dist`, which in turn hands off to `rustup-utils` and
`download` (the crate). Hopefully this clean-up makes it
a little easier to figure out what's going on with downloads
for future work.
    @jelford
    jelford committed May 22, 2017
    Configuration menu
    Copy the full SHA
    df030d5 View commit details
    Browse the repository at this point in the history

  2. Move download-related code out of dist and into its own download mod 

    The idea here is to reduce the API surface of `dist`, while
consolidating download-related code into a single place. Was also able
to remove a number of pointless pass-arounds of the
`notification_handler` attached to DownloadCfg (haven't caught them all
yet).
    @jelford
    jelford committed May 22, 2017
    Configuration menu
    Copy the full SHA
    effdfef View commit details
    Browse the repository at this point in the history

  3. Add missing newline

    @Diggsey
    Diggsey committed May 22, 2017
    Configuration menu
    Copy the full SHA
    61f641a View commit details
    Browse the repository at this point in the history