Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of Cargo completions for ZSH (issue #1821) #1995

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

burjui
Copy link
Contributor

@burjui burjui commented Sep 15, 2019

When sourceing the original completion file, the #compdef cargo line at the start is ignored, and ZSH does not autoload the completions, so rustup must put it the generated _cargo as well.
I guess rustup does not create a symlink instead, because that would be less portable.

@kinnison
Copy link
Contributor

I do not use zsh completions with cargo; but I can appreciate others might -- is there anyone who can confirm if this is sufficient to make things work?

@ehuss
Copy link
Contributor

ehuss commented Sep 16, 2019

I don't normally use zsh, but I tried this out and it seems to work (zsh 5.7.1). Looks like it needs a rustfmt though.

@burjui
Copy link
Contributor Author

burjui commented Sep 16, 2019

@ehuss Done.

@kinnison kinnison merged commit 1e6b056 into rust-lang:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants