Catch potential misuses of target triples in host triple position #869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before executing the
default
andtoolchain add
actions, check if the toolchain given has a different triple than host. If so, bail out with a hint explaining the subcommands and suggestingtarget add
instead.This is based on the assumption that one can't execute binaries from a different triple; however there are niche scenarios where it is actually possible, by QEMU user emulation and similar means. We might add a
-f
switch for forcing the old behavior if it turns out to be necessary for the relevant parties.
Fixes #826.
Fixes #834.
NOTE: Tests are missing now. I'm developing the patch on MIPS64 so the test machinery was unavailable. I'll have to sync my AMD64 box for completing this.