Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny 2018 idiom lints #1108

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Deny 2018 idiom lints #1108

merged 1 commit into from
Apr 7, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Apr 5, 2021

error: hidden lifetime parameters in types are deprecated
  --> library/stdarch/crates/std_detect/src/detect/os/linux/cpuinfo.rs:20:48
   |
20 |     pub(crate) fn field(&self, field: &str) -> CpuInfoField {
   |                                                ^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
   |
   = note: `-D elided-lifetimes-in-paths` implied by `-D warnings`

This lint is allow by default, which is why this wasn't spotted earlier.

cc rust-lang/rust#83776 (comment)

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented Apr 5, 2021

Could you add #![deny(rust_2018_idioms)] at the crate root for all crates?

@jyn514
Copy link
Member Author

jyn514 commented Apr 5, 2021

Looks like CI is stuck?

@Amanieu
Copy link
Member

Amanieu commented Apr 5, 2021

It's stuck in rust-lang/rust too. Let's just wait it out.

This lint is allow by default, which is why this wasn't spotted earlier.
It's denied by rust-lang/rust, so it's good to warn about it here so it
can be fixed more quickly.
@jyn514
Copy link
Member Author

jyn514 commented Apr 6, 2021

Yay, CI is finally passing :D

@Amanieu Amanieu merged commit e374266 into rust-lang:master Apr 7, 2021
@jyn514 jyn514 deleted the warning branch April 7, 2021 04:53
Amanieu pushed a commit that referenced this pull request Apr 12, 2021
This lint is allow by default, which is why this wasn't spotted earlier.
It's denied by rust-lang/rust, so it's good to warn about it here so it
can be fixed more quickly.
jyn514 added a commit to jyn514/rust that referenced this pull request Apr 12, 2021
This also includes a cherry-pick of
rust-lang/stdarch@ec14619
and rust-lang/stdarch#1108 to fix a build
failure.

It also adds a re-export of various macros to the crate root of libstd -
previously they would show up automatically because std_detect was defined
in the same crate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants