Update aarch64 linux feature detection #1146
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
This change makes your PR failed to compile. You can rebase to the latest master branch to avoid this error. |
adamgemmell
force-pushed
the
aarch64-detect
branch
from
9411f39
to
e7f551f
Compare
| @FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] crypto: "crypto"; | ||
| /// Crypto: AES + PMULL + SHA1 + SHA2 | ||
| /// Cryptographic Extension (AES + PMULL + SHA1 + SHA2-256) |
There was a problem hiding this comment.
As per my comment in rust-lang/rust#84665, we should remove crypto and instead only expose aes and sha2.
|
These changes will only work when my changes to rustc make it to the nightly compiler, see rust-lang/rust#84665 Hence no reason to run the CI yet |
…nieu Update list of allowed aarch64 features I recently added these features to std_detect for aarch64 linux, pending [review](rust-lang/stdarch#1146). I have commented any features not supported by LLVM 9, the current minimum version for Rust. Some (PAuth at least) were renamed between 9 & 12 and I've left them disabled. TME, however, is not in LLVM 9 but I've left it enabled. See rust-lang/stdarch#993
Update list of allowed aarch64 features I recently added these features to std_detect for aarch64 linux, pending [review](rust-lang/stdarch#1146). I have commented any features not supported by LLVM 9, the current minimum version for Rust. Some (PAuth at least) were renamed between 9 & 12 and I've left them disabled. TME, however, is not in LLVM 9 but I've left it enabled. See rust-lang/stdarch#993
This commit doesn't add support for features not available in LLVM 12
adamgemmell
force-pushed
the
aarch64-detect
branch
from
0fcbadb
to
cf5fb09
Compare
|
I missed this in my testing but armv7 still requires crypto for the intrinsics. This was fixed in llvm/llvm-project@b8baa2a#diff-e65dd2f7194df68bc6e9b754449ae241a6717f77ca1a28ee9479990ffe292049R7230 but that commit needs to make it to the minimum LLVM version before it can be removed fully |
|
We can cherry-pick that commit into rust-lang/llvm-project and then update the llvm-project submodule in rust-lang/rust. |
|
Hmm on second thought that might be a breaking change that would prevent cross-lang LTO with Clang 12. So in the end we will most likely have to wait for LLVM 13. |
All features supported by auxv (see https://github.com/torvalds/linux/blob/master/arch/arm64/include/uapi/asm/hwcap.h) / cpuinfo (https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinfo.c) and in LLVM 12 are added.
See
llvm-project/llvm/lib/Target/AArch64/AArch64.tdfor the LLVM feature names and dependencies. We've done a few passes for silly cross-referencing mistakes ourselves so I'm reasonably confident in its accuracy.I had a couple notes after working on this:
See #993
See also: rust-lang/rust#84665