[arm] vadd, vaddd, vaddq, vaddl #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnzlbg
force-pushed
the
neon_intrinsics
branch
4 times, most recently
from
7083d74
to
8682779
Compare
gnzlbg
force-pushed
the
neon_intrinsics
branch
from
8682779
to
8ee1812
Compare
| (i32x2, i64x2, as_i64x2), | ||
| (u8x8, u16x8, as_u16x8), | ||
| (u16x4, u32x4, as_u32x4), | ||
| (u32x2, u64x2, as_u64x2) |
There was a problem hiding this comment.
Oh I thought these were only for sem-width casts? What are the semantics of the different-width casts? Does each lane just get promoted?
There was a problem hiding this comment.
Does each lane just get promoted?
Yes, that's what simd_cast does and what I intended. @BurntSushi how did you envision this? The number of as_... functions is going to explode if I keep doing this for the arm intrinsics. I would be fine with it, but maybe we should consider providing simd_cast as part of the library API.
|
@BurntSushi @alexcrichton I've filled #151 to discuss this. Right now this blocks the |
BurntSushi
approved these changes
Oct 26, 2017
|
@alexcrichton and I talked about this in person and we're good with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.