Use const {} for the immediate args of _mm*_cmp_* #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rustc_codegen_cranelift requires immediates to already be constant in MIR unlike LLVM which only needs them constant after optimizations.
|
r? @Amanieu (rustbot has picked a reviewer for you, use r? to override) |
|
Required for some of the intrinsics in https://github.com/bjorn3/rustc_codegen_cranelift/pull/1380 |
|
Wouldn't be better to make a shorthand macro |
lu-zero
approved these changes
Jun 23, 2023
|
That would be nice if this pattern happened more. Right now I'm not sure if it is worth it. |
|
On powerpc there are few more places, but that is probably far in the future :) |
|
Yeah, Cranelift doesn't support PowerPC yet: bytecodealliance/wasmtime#1183. It does support s390x though. |
|
I might contribute support for those intrinsics as well, but again, it can wait for later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustc_codegen_cranelift requires immediates to already be constant in MIR unlike LLVM which only needs them constant after optimizations.