Work around CI failures for the ARM target #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These seem to have been introduced by recent LLVM changes. * The instruction limit for vld*/vst* has been raised. This is not a significant issue, it is only used for testing. * vld*/vst* instructions are generated with overly strict alignments: rust-lang#1217 * vtbl/vtbx instrinsics are failing intrinsic-test for unknown reasons.
|
@Amanieu: no appropriate reviewer found, use r? to override |
|
@jacobbramley Do you think the vtbl/vtbx issue might be related to rust-lang/rust#112460? |
I think it's different, not least because I think the vtbl/vtbx issue seems to affect AArch64 too. (AArch64 doesn't have the alignment hints seen in #1217.) We just noticed those too, but we weren't looking at the latest |
|
The issue seems to be fixed in the latest rustc, so I ended up reverting this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seem to have been introduced by recent LLVM changes.